fix: incorrect paths to CLI resources and files break commands #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CLI commands are broken due to incorrect paths to resources. - `postinstall` is broken as the path to common helpers is incorrect. Also we are not injecting correct constants and the generation of `.html` for `test init` command fails. Inject correct constants when generating help. - `test init` command is broken as path to CLI's resource dir is not correct
DimitarTachev
approved these changes
Jan 29, 2019
dtopuzov
approved these changes
Jan 29, 2019
rosen-vladimirov
deleted the
vladimirov/fix-getting-paths-to-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CLI commands are broken due to incorrect paths to resources.
postinstallis broken as the path to common helpers is incorrect. Also we are not injecting correct constants and the generation of.htmlfortest initcommand fails. Inject correct constants when generating help.test initcommand is broken as path to CLI's resource dir is not correctPR Checklist
What is the current behavior?
tns dev-post-install-clicommand fails.tns dev-generate-helpcommand fails.tns test initcommand fails.What is the new behavior?
Mentioned commands are working.