Skip to content

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 11, 2019

If you delete node_modules of application and try to execute tns prepare or tns build, the following error is thrown:

Error: Cannot find module '<path-to-project>/node_modules/webpack/bin/webpack.js'
 at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15)
    at Function.Module._load (internal/modules/cjs/loader.js:506:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:741:12)
    at startup (internal/bootstrap/node.js:285:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)
Executing webpack failed with exit code 1.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Jun 11, 2019
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is this the correct place? Is this a service in this case or controller?

@Fatme
Copy link
Contributor Author

Fatme commented Jun 12, 2019

It should be controller - I'll handle this in a separate PR.

@Fatme Fatme merged commit 3531838 into feature/webpack-only Jun 12, 2019
@Fatme Fatme deleted the fatme/ensure-dependencies-are-installed branch June 12, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants