Support for android MNC #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| let manifestPath = path.join(projectRoot, "AndroidManifest.xml"); | ||
| let apiLevel = this.getTarget(projectRoot).wait().split('-')[1]; | ||
| if (apiLevel === "MNC") { // MNC SDK requires that minSdkVersion is set to "MNC" | ||
| shell.sed('-i', /android:minSdkVersion=".*"/, `android:minSdkVersion="${apiLevel}"`, manifestPath); |
There was a problem hiding this comment.
should you include ? in the regex. If you have line android:minSdkVersion="L" android:smthElse="Value", the match will be everything up to Value".
|
❌ |
|
✅ |
|
👍 after green build |
| // TODO: parametrize targetSdk | ||
| var targetSdk = "android-17"; | ||
| let targetSdk = this.getTarget(projDir).wait() || "android-17"; |
There was a problem hiding this comment.
Why do we need this change here? This will update only project.properties file
There was a problem hiding this comment.
After personal discussion we decided to fix this in a separate PR.
Whitelist MNC SDK change all vars to lets When building with MNC SDK, change minSdkVersion to be MNC, required for succesful build See #507
|
✅ |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitelist MNC SDK
change all vars to lets
When building with MNC SDK, change minSdkVersion to be MNC, required for succesful build
Use latest common lib to support MNC emulator
See #507