Skip to content

feat: support livesync in remote machine #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2021
Merged

feat: support livesync in remote machine #5560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
759d486
feat: support livesync in remote machine
edusperoni Aug 8, 2021
c217fc4
Update lib/services/livesync/android-device-livesync-service.ts
rigor789 Aug 11, 2021
8e115dc
Update lib/services/livesync/android-livesync-tool.ts
rigor789 Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/services/livesync/android-device-livesync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,13 @@ export class AndroidDeviceLiveSyncService
let isResolved = false;
const socket = new net.Socket();

socket.connect(this.port, "127.0.0.1", () => {
socket.write(Buffer.from([0, 0, 0, 1, 1]));
});
socket.connect(
this.port,
process.env.NATIVESCRIPT_LIVESYNC_ADDRESS || "127.0.0.1",
() => {
socket.write(Buffer.from([0, 0, 0, 1, 1]));
}
);
socket.on("data", (data: any) => {
isResolved = true;
socket.destroy();
Expand Down
3 changes: 2 additions & 1 deletion lib/services/livesync/android-livesync-tool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
}

if (!configuration.localHostAddress) {
configuration.localHostAddress = DEFAULT_LOCAL_HOST_ADDRESS;
configuration.localHostAddress =
process.env.NATIVESCRIPT_LIVESYNC_ADDRESS || DEFAULT_LOCAL_HOST_ADDRESS;
}

const connectTimeout = configuration.connectTimeout || TRY_CONNECT_TIMEOUT;
Expand Down