Support for dynamic frameworks in iOS from plugins #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ |
Fatme
force-pushed
the
fatme/dynamic-libraries-support
branch
from
fb7c9a6 to
79e4ad2
Compare
|
✅ |
| @@ -273,13 +275,13 @@ class AndroidProjectService implements IPlatformProjectService { | |||
| let libsFolderContents = this.$fs.readDirectory(libsFolderPath).wait(); | |||
| _(libsFolderContents) | |||
| .filter(libsFolderItem => path.extname(libsFolderItem) === ".jar") | |||
| .map(jar => this.addLibrary(this.platformData, path.join(libsFolderPath, jar)).wait()) | |||
| .map(jar => this.addLibrary(path.join(libsFolderPath, jar)).wait()) | |||
There was a problem hiding this comment.
.map converts (maps) its input values to its output values. In this case, .each is a better choice.
|
👍 After addressing comments |
|
❌ |
Mitko-Kerezov
force-pushed
the
fatme/dynamic-libraries-support
branch
from
433e2f4 to
8a4df65
Compare
|
✅ |
Mitko-Kerezov
force-pushed
the
fatme/dynamic-libraries-support
branch
from
8a4df65 to
55f92f1
Compare
|
✅ |
Mitko-Kerezov
added a commit
that referenced
this pull request
Jul 16, 2015
…port Support for dynamic frameworks in iOS from plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#510