Fixes and improvements #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/fixes-and-improvements
branch
from
29177c8 to
328982a
Compare
| @@ -63,7 +63,9 @@ export class NodePackageManager implements INodePackageManager { | |||
| } | |||
|
|
|||
| var incrementedVersion = semver.inc(currentVersion, constants.ReleaseType.MINOR); | |||
| packageName = packageName + "@" + "<" + incrementedVersion; | |||
| if(packageName.indexOf("@") < 0) { | |||
| packageName = packageName + "@" + "<" + incrementedVersion; | |||
There was a problem hiding this comment.
Do we add the "<" separately for readability? Cause that is yet another string concatenation, making the operation a bit slower.
|
Looks good to me, 👍 |
Fatme
force-pushed
the
fatme/fixes-and-improvements
branch
from
328982a to
02cc9cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.