Skip to content

Conversation

VladimirAmiorkov
Copy link
Contributor

Developer notes

This PR resolves occasional issues where the NativeScript CLI cannot or wrongfully transfers the dSYM file causing debugging to not be possible for iOS.

PR features:

  • Improve the 'timing' issues that could occur between child processes of the plugin and those that NativeScript CLI triggers internally by splitting them leading to the NativeScript CLI processes not being managed by the plugin during file watcher changes but only on full exit (Ctr+C)
  • Above change improves the rebuild time after a change during file watching (attach & watch) by using the NativeScript CLI livesync

feat: split executing of 'tns' commands and native builds from file watcher
#2
@VladimirAmiorkov VladimirAmiorkov self-assigned this Feb 13, 2019
@VladimirAmiorkov VladimirAmiorkov requested a review from a team February 13, 2019 14:55
@VladimirAmiorkov VladimirAmiorkov merged commit 2ca2d44 into master Feb 13, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the amiorkov/child-processes-improvements branch February 13, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant