Webpack bundled app can't find modules when app is closed to run as a background service

[devyaz]

This is app runs when built in legacy it uses a background service to receive massages and other real-time content, but when bundled and the app is closed app crashes, it can't find modules required in NotificatinIntentService! I asked here at SO https://stackoverflow.com/questions/56777821/webpack-bundle-cant-find-a-module-when-in-background ,Error: com.tns.NativeScriptException: Failed to find module: "../db", relative to: app/notifications/
this is NotificationIntentService.js

tried changing relative paths it doesn't work!

this is NotificationIntentService.js where it requires the modules needed for background communication(real time notifications and messages)

    onHandleIntent: function (intent) {
        var action = intent.getAction();
        if ("ACTION_START" == action) {
            processStartNotification();
        }
  android.support.v4.content.WakefulBroadcastReceiver.completeWakefulIntent(intent);
    }
});
const db=require("../db")
var LocalNotifications_1= require("nativescript-local-notifications");
var Vibrate = require("nativescript-vibrate").Vibrate;
var vibrator = new Vibrate();
var color_1 = require('tns-core-modules/color');
var dialogs_1 = require("tns-core-modules/ui/dialogs");
var model=require("../view");
var frameModule = require("tns-core-modules/ui/frame");
 model.checkStatus()
var io=require('../connection').io;
var iD=0
function processStartNotification() {
    // Do something. For example, fetch fresh data from backend to create a rich notification?
    var utils = require("tns-core-modules/utils/utils");
    var context = utils.ad.getApplicationContext();
    var ID=0;
}

function getDeleteIntent(context) {
        var intent = new android.content.Intent(context, com.tns.broadcastreceivers.NotificationEventReceiver.class);
        intent.setAction("ACTION_DELETE_NOTIFICATION");
        return android.app.PendingIntent.getBroadcast(context, 0, intent, android.app.PendingIntent.FLAG_UPDATE_CURRENT);
}

It seems after bundling paths can't be resolved while in background all others work while app is 'live'
Replicate
Create an app with a background service that requires modules like database, connection to server , when closed app set's an alarm service firing every 5 min, it shouldn't error.
I tried changing relative paths

[rosen-vladimirov]

Hey @devyaz ,
Can you please share a demo project reproducing this behavior? This will allow us to investigate this issue faster and provide more meaningful help.
Thanks in advance for your time!

[devyaz]

I'll do as soon as am near my Dev pc

…

On Thu., 27 Jun. 2019, 12:52 Rosen Vladimirov, ***@***.***> wrote: Hey @devyaz <https://github.com/devyaz> , Can you please share a demo project reproducing this behavior? This will allow us to investigate this issue faster and provide more meaningful help. Thanks in advance for your time! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#952?email_source=notifications&email_token=AE35ASMKYWI4TQKFM7EMSU3P4SLXBA5CNFSM4H32DIRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWXX2Y#issuecomment-506297323>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE35ASPCDRPKFQ7I7J5HDNTP4SLXBANCNFSM4H32DIRA> .

[devyaz]

@rosen-vladimirov here's the app attached just tns install ,build and run then close app it should stay closed no errors in legacy but errors when bundled! Try setTimout to show a notification it should open the app when tapped
github.zip

[DimitarTachev]

Hi @devyaz,

The issue is caused by the webpack.config which contains:

new CopyWebpackPlugin([
  { from: { glob: "fonts/**" } },
  { from: { glob: "**/*.jpg" } },
  { from: { glob: "**/*.png" } },
  { from: { glob: "notifications/**" } },
  { from: { glob: "activities/**" } },
  { from: { glob: "broadcastreceivers/**" } }

The CopyWebpackPlugin should be used only for static resources like image, fonts and databases.

The JavaScript files of the Android Services and Activities should be added in the appComponents array as shown below:

// Add your custom Activities, Services and other android app components here.
const appComponents = [
  "tns-core-modules/ui/frame",
  "tns-core-modules/ui/frame/activity",
  resolve(__dirname, "app/broadcastreceivers/NotificationEventReceiver"),
  resolve(__dirname, "app/broadcastreceivers/NotificationServiceStarterReceiver"),
  resolve(__dirname, "app/notifications/NotificationIntentService"),
  resolve(__dirname, "app/activities/NotificationActivity"),
    ];

P.S. Don't forget to update your CopyWebpackPlugin as follows:

new CopyWebpackPlugin([
  { from: { glob: "fonts/**" } },
  { from: { glob: "**/*.jpg" } },
  { from: { glob: "**/*.png" } }

[devyaz]

@DimitarTachev @rosen-vladimirov i made he changes, i get new error related to nativescript-vibrate plugin
in vendor.js
the line

        var _this = _super.call(this) || this;
        _this.service =
app.android.context.getSystemService(android.content.Context.VIBRATOR_SERVICE);
        return _this;
    }

the error:

System.err: TypeError: Cannot read property 'getSystemService' of undefined
System.err: File: "<unknown>, line: 1, column: 265
System.err:
System.err: StackTrace:
System.err:     Frame: function:'Vibrate',
file:'file:///data/data/com.MalaChat.a
io/files/app/vendor.js', line: 4235, column: 45
System.err:     Frame: function:'./connection.js',
file:'file:///data/data/com.Ma
laChat.aio/files/app/bundle.js', line: 705, column: 17
System.err:     Frame: function:'__webpack_require__',
file:'file:///data/data/co
m.MalaChat.aio/files/app/runtime.js', line: 751, column: 30
System.err:     Frame: function:'fn',
file:'file:///data/data/com.MalaChat.aio/fi
les/app/runtime.js', line: 121, column: 20
System.err:     Frame:
function:'./notifications/NotificationIntentService.js', f
ile:'file:///data/data/com.MalaChat.aio/files/app/bundle.js', line: 1657,
column:
8

[DimitarTachev]

Hi @devyaz,

This error is thrown because the Bundle workflow requires the JavaScript files of the Android Services and Activities before the application start and you cannot use any application related code in the root scope of these files (the Vibrate class is using some methods from the tns-core-modules application which is not ready yet).

In other words, you should move the following lines:

const db = require("../db")
var LocalNotifications_1 = require("nativescript-local-notifications");
var Vibrate = require("nativescript-vibrate").Vibrate;
var vibrator = new Vibrate();
var color_1 = require('tns-core-modules/color');
var dialogs_1 = require("tns-core-modules/ui/dialogs");
var model = require("../view");
var frameModule = require("tns-core-modules/ui/frame");
model.checkStatus()
var io = require('../connection').io;
var iD = 0

somewhere in the service methods (e.g. in processStartNotification) in order to execute this code when the NativeScript application is ready.

[devyaz]

Ok I'll try this evening and report back

…

On Thu., 4 Jul. 2019, 15:52 Dimitar Tachev, ***@***.***> wrote: Hi @devyaz <https://github.com/devyaz>, This error is thrown because the Bundle workflow requires the JavaScript files of the Android Services and Activities before the application start and you cannot use any application related code in the root scope of these files (the Vibrate class is using some methods from the tns-core-modules application which is not ready yet). In other words, you should move the following lines: const db = require("../db")var LocalNotifications_1 = require("nativescript-local-notifications");var Vibrate = require("nativescript-vibrate").Vibrate;var vibrator = new Vibrate();var color_1 = require('tns-core-modules/color');var dialogs_1 = require("tns-core-modules/ui/dialogs");var model = require("../view");var frameModule = require("tns-core-modules/ui/frame");model.checkStatus()var io = require('../connection').io;var iD = 0 somewhere in the service methods (e.g. in processStartNotification) in order to execute this code when the NativeScript application is ready. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#952?email_source=notifications&email_token=AE35ASI766LASB6X57JVFQDP5X6AJA5CNFSM4H32DIRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZHPC3A#issuecomment-508490092>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE35ASIGFA2Z2Z6SXE7HLNLP5X6AJANCNFSM4H32DIRA> .

[devyaz]

@DimitarTachev @rosen-vladimirov i followed your advice and now app starts fine but when closed this is what it throws

System.err: java.lang.RuntimeException: Unable to start service com.tns.notifications.NotificationIntentService@537c768 with Intent { act=ACTION_START cmp=com.MalaChat.aio/com.tns.notifications.NotificationIntentService (has extras) }: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Message android.app.IntentService$ServiceHandler.obtainMessage()' on a null object reference
System.err:     at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3383)
System.err:     at android.app.ActivityThread.-wrap21(ActivityThread.java)
System.err:     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1612)
System.err:     at android.os.Handler.dispatchMessage(Handler.java:102)
System.err:     at android.os.Looper.loop(Looper.java:154)
System.err:     at android.app.ActivityThread.main(ActivityThread.java:6236)
System.err:     at java.lang.reflect.Method.invoke(Native Method)
System.err:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:891)
System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:781)
System.err: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Message android.app.IntentService$ServiceHandler.obtainMessage()' on a null object reference
System.err:     at android.app.IntentService.onStart(IntentService.java:119)
System.err:     at android.app.IntentService.onStartCommand(IntentService.java:133)
System.err:     at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3366)
System.err:     ... 8 more

webpack config

const appComponents = [
        "tns-core-modules/ui/frame",
        "tns-core-modules/ui/frame/activity",
        resolve(__dirname, "app/broadcastreceivers/NotificationEventReceiver"),
        resolve(__dirname, "app/broadcastreceivers/NotificationServiceStarterReceiver"),
        resolve(__dirname, "app/notifications/NotificationIntentService"),
        resolve(__dirname, "app/activities/NotificationActivity"),
        resolve(__dirname, "app/service-helper"),
    ];

[DimitarTachev]

Hi @devyaz,

Thanks for updating us back!

We were getting the same exception with your app both with the Legacy and the Bundle workflow. Please open a new issue in the Android Runtime or ask a question in StackOverflow as this is not related with the Bundle workflow anymore.

[devyaz]

Now that you mentioned it even in legacy it's the same, before I submitted this issue I could run it without exceptions,even the APK(I can share if needed) I built before runs without exception it can receive notifications when closed! But after {N} 5.4 everything changed so am very positive it's got everything to do with either {N} or webpack, I'll downgrade and try again then upgrade but run/build in legacy then report

[devyaz]

@rosen-vladimirov @DimitarTachev i downgraded to 5.3.4 and everything worked i got notifications while app closed, an hour ago i upgrades to {N}5.4.2
tns platform remove android
then ./node_modules/.bin/update-ns-webpack --deps --config
then tns update
then tns run android --bundle

guess what when app closed?

JS: gone awol
JS: onReceive from alarm, starting notification service! thread: main
System.err: java.lang.RuntimeException: Unable to start service com.tns.notifications.NotificationIntentService@ee179c5 with Intent { act=ACTION_START cmp=com.MalaChat.aio/com.tns.notifications.NotificationIntentService (has extras) }: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Message android.app.IntentService$ServiceHandler.obtainMessage()' on a null object reference
System.err:     at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3383)

so am positive its got to do with webpack/ or {N}5.4.2 now after upgrading even legacy throws an exception

[devyaz]

last options? otherwise am good to revert to old {N}5.3.4