feat: support V8 snapshots on Windows #1055

DimitarTachev · 2019-09-26T08:01:47Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

Providing the --env.snapshot flag on Windows is throwing an exception.

The --env.snapshot flag is valid on Windows and it is generating snapshots in a docker container.

DimitarTachev · 2019-09-30T12:38:58Z

test

cla-bot bot added the cla: yes label Sep 26, 2019

DimitarTachev mentioned this pull request Sep 26, 2019

feat: support snapshots on Windows NativeScript/nativescript-cli#5037

Merged

5 tasks

Fatme approved these changes Sep 26, 2019

View reviewed changes

DimitarTachev added 3 commits September 27, 2019 14:25

feat: support V8 snapshots on Windows

2e9b753

fix: fix xxd path for local snapshots generation

f63d493

feat: ensure valid CLI version when Windows snapshot is requested

3a687c0

DimitarTachev force-pushed the tachev/snapshot-on-windows branch from 7a8d017 to 3a687c0 Compare September 27, 2019 13:29

Fatme approved these changes Sep 27, 2019

View reviewed changes

DimitarTachev merged commit 488730d into master Oct 2, 2019

DimitarTachev deleted the tachev/snapshot-on-windows branch October 2, 2019 06:15