This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Buhov/local snapshot improvements #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m on demand before snapshot generation
…ual to true only when in snapshot context
sis0k0
reviewed
Jun 19, 2017
| this.generateTnsJavaClassesFile({ output: tnsJavaClassesDestination, options: generationOptions.tnsJavaClassesOptions }); | ||
| } | ||
|
|
||
| var snapshotToolsPath = generationOptions.snapshotToolsPath ? |
There was a problem hiding this comment.
style: let's make it an arrow func instead of using ternary operator 2 times
| const generator = new SnapshotGenerator({ buildPath: this.getBuildPath() }); | ||
| const generatorBuildPath = generator.generate({ | ||
| return generator.generate({ | ||
| snapshotToolsPath: snapshotToolsPath, |
There was a problem hiding this comment.
style: just snapshotToolsPath is more readable
| options: options.tnsJavaClassesOptions | ||
| }); | ||
|
|
||
| // Run the snapshot tool when the packing is done |
There was a problem hiding this comment.
style: update the comment, too, or remove it
| } | ||
| module.exports = SnapshotGenerator; | ||
|
|
||
| SnapshotGenerator.MKSNAPSHOT_TOOLS_PATH = path.join(__dirname, "snapshot-generator-tools/mksnapshot"); |
There was a problem hiding this comment.
style suggestion:
const { join, dirname } = require("path");
...
const getAbsolutePath = path => join(__dirname, path);
There was a problem hiding this comment.
Why do you think we need getAbsolutePath function? It is as verbose as using join(__dirname, path) but I find join(__dirname, path) to be more clear.
| } | ||
|
|
||
| SnapshotGenerator.prototype.getMksnapshotToolsDirOrThrow = function(v8Version) { | ||
| var snapshotToolsDownloads = {}; |
| }); | ||
| } | ||
|
|
||
| var downloadUrl = "https://raw.githubusercontent.com/NativeScript/mksnapshot-tools/production/" + mksnapshotToolRelativePath; |
There was a problem hiding this comment.
const and maybe we should extract the url to some global var
| throw new Error("Can't find mksnapshot tool for " + arch + " at path " + currentArchMksnapshotToolPath); | ||
| } | ||
|
|
||
| var androidArch = this.convertToAndroidArchName(arch); |
| var currentArchBlobOutputPath = path.join(this.buildPath, "snapshots/blobs", androidArch); | ||
| shelljs.mkdir("-p", currentArchBlobOutputPath); | ||
| var stdErrorStream = fs.openSync(mksnapshotStdErrPath, 'w'); | ||
| child_process.execSync(currentArchMksnapshotToolPath + " " + inputFile + " --startup_blob " + path.join(currentArchBlobOutputPath, "TNSSnapshot.blob") + " --profile_deserialization", {encoding: "utf8", stdio: [process.stdin, process.stdout, stdErrorStream]}); |
| var currentArchBlobOutputPath = path.join(this.buildPath, "snapshots/blobs", androidArch); | ||
| shelljs.mkdir("-p", currentArchBlobOutputPath); | ||
| var stdErrorStream = fs.openSync(mksnapshotStdErrPath, 'w'); | ||
| child_process.execSync(currentArchMksnapshotToolPath + " " + inputFile + " --startup_blob " + path.join(currentArchBlobOutputPath, "TNSSnapshot.blob") + " --profile_deserialization", {encoding: "utf8", stdio: [process.stdin, process.stdout, stdErrorStream]}); |
There was a problem hiding this comment.
erm, let's use exec and not pipe the error stream to a file
| var currentArchSrcOutputPath = path.join(this.buildPath, "snapshots/src", androidArch); | ||
| shelljs.mkdir("-p", currentArchSrcOutputPath); | ||
| shellJsExecuteInDir(currentArchBlobOutputPath, function(){ | ||
| shelljs.exec("xxd -i TNSSnapshot.blob > " + path.join(currentArchSrcOutputPath, "TNSSnapshot.c")); |
There was a problem hiding this comment.
let's extract TNSSnapshot (the filename) to a const somewhere
ivanbuhov
force-pushed
the
buhov/local-snapshot-improvements
branch
from
24778ab to
d18fd66
Compare
sis0k0
approved these changes
Jun 20, 2017
|
groceries |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mksnapshottools are now downloaded on demand before running them__snapshotand__snapshotEnabledglobal variables:__snapshotEnabled-> has a value oftrueif snapshot is loaded in the app__snapshot-> has a value oftruewhen the executed code is in snapshot context andfalsewhen the code is executed on device/emulatorplatforms/android/buildfolder on snapshot generation in order to trigger full rebuild of the.apkfilesinclude.gradlefile even when blobs are used in order to exclude the snapshotted file from the apk.ANDROID_NDK_HOMEenv variable in case androidNdkPath is not specified