This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: optimize platform specific files resolver #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
approved these changes
Jan 30, 2019
SvetoslavTsenov
pushed a commit
that referenced
this pull request
Feb 1, 2019
## What is the current behavior? The platform specific files resolver for `.tns`, `.ios`, `.android` files is having performance issues on webpack and seems to break (make it run very slow like its for the first time) the incremental compilation. This is happening in big projects with many files in the `node_modules` directory, as the current implementation makes a file system call for each file. ## What is the new behavior? The resolver now handles only the files that are considered to support platform specific names e.g: * packages in `node_modules` with `nativescript`, `tns` or `ns` anywhere in the name * only files with following extensions: `[".ts", ".js", ".scss", ".less", ".css", ".html", ".xml", ".vue", ".json"]`
SvetoslavTsenov
added a commit
that referenced
this pull request
Feb 1, 2019
* fix: optimize platform specific files resolver (#782) ## What is the current behavior? The platform specific files resolver for `.tns`, `.ios`, `.android` files is having performance issues on webpack and seems to break (make it run very slow like its for the first time) the incremental compilation. This is happening in big projects with many files in the `node_modules` directory, as the current implementation makes a file system call for each file. ## What is the new behavior? The resolver now handles only the files that are considered to support platform specific names e.g: * packages in `node_modules` with `nativescript`, `tns` or `ns` anywhere in the name * only files with following extensions: `[".ts", ".js", ".scss", ".less", ".css", ".html", ".xml", ".vue", ".json"]` * release: cut the 0.19.2 release * docs: update changelog
SvetoslavTsenov
added a commit
that referenced
this pull request
Feb 1, 2019
* fix: optimize platform specific files resolver (#782) ## What is the current behavior? The platform specific files resolver for `.tns`, `.ios`, `.android` files is having performance issues on webpack and seems to break (make it run very slow like its for the first time) the incremental compilation. This is happening in big projects with many files in the `node_modules` directory, as the current implementation makes a file system call for each file. ## What is the new behavior? The resolver now handles only the files that are considered to support platform specific names e.g: * packages in `node_modules` with `nativescript`, `tns` or `ns` anywhere in the name * only files with following extensions: `[".ts", ".js", ".scss", ".less", ".css", ".html", ".xml", ".vue", ".json"]` * release: cut the 0.19.2 release * docs: update changelog
SvetoslavTsenov
added a commit
that referenced
this pull request
Feb 1, 2019
* fix: optimize platform specific files resolver (#782) ## What is the current behavior? The platform specific files resolver for `.tns`, `.ios`, `.android` files is having performance issues on webpack and seems to break (make it run very slow like its for the first time) the incremental compilation. This is happening in big projects with many files in the `node_modules` directory, as the current implementation makes a file system call for each file. ## What is the new behavior? The resolver now handles only the files that are considered to support platform specific names e.g: * packages in `node_modules` with `nativescript`, `tns` or `ns` anywhere in the name * only files with following extensions: `[".ts", ".js", ".scss", ".less", ".css", ".html", ".xml", ".vue", ".json"]` * release: cut the 0.19.2 release * docs: update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The platform specific files resolver for
.tns,.ios,.androidfiles is having performance issues on webpack and seems to break (make it run very slow like its for the first time) the incremental compilation. This is happening in big projects with many files in thenode_modulesdirectory, as the current implementation makes a file system call for each file.What is the new behavior?
The resolver now handles only the files that are considered to support platform specific names e.g:
node_moduleswithnativescript,tnsornsanywhere in the name[".ts", ".js", ".scss", ".less", ".css", ".html", ".xml", ".vue", ".json"]