This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: Emit inspector_modules.js as a separate entry point for iOS #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iOS Runtime calls it explicitly by name and it has to be emitted in `tns_modules/tns_core_modules` Refs: NativeScript/ios-jsc#1054, NativeScript/ios-jsc#1055 NativeScript/ios-jsc#1056, NativeScript/ios-jsc#1057
mbektchiev
force-pushed
the
bektchiev/emit-inspector-modules-entry
branch
from
495b836 to
00ecaa0
Compare
mbektchiev
force-pushed
the
bektchiev/emit-inspector-modules-entry
branch
2 times, most recently
from
113c605 to
1d4b071
Compare
The default setting causes the WebPack runtime to be loaded twice because the `inspector_modules` module is loaded by the iOS runtime as a secondary entry point. This has some undesirable implications as [stated in the documentation](https://webpack.js.org/configuration/optimization/#optimizationruntimechunk): > Imported modules are initialized for each runtime chunk separately, > so if you include multiple entry points on a page, beware of this > behavior. You will probably want to set it to single or use another > configuration that allows you to only have one runtime instance.
mbektchiev
force-pushed
the
bektchiev/emit-inspector-modules-entry
branch
from
1d4b071 to
6e780af
Compare
vakrilov
approved these changes
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iOS Runtime calls it explicitly by name and it has to be emitted
in
tns_modules/tns_core_modulesRefs: NativeScript/ios-jsc#1054, NativeScript/ios-jsc#1055
NativeScript/ios-jsc#1056, NativeScript/ios-jsc#1057
PR Checklist