fix(hmr): run ts-loader in transpileOnly mode #878

vakrilov · 2019-05-01T13:45:43Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

ts-loader running in transpileOnly mode with HMR (as suggested in docs). Type-checking assured with fork-ts-checker-webpack-plugin (also as suggested in the ts-loader docs)

fix(hmr): run ts-loader in transpileOnly mode

4a6d9da

cla-bot bot added the cla: yes label May 1, 2019

ghost assigned vakrilov May 1, 2019

ghost added new PR review labels May 1, 2019

vakrilov marked this pull request as ready for review May 2, 2019 06:12

Fatme approved these changes May 8, 2019

View reviewed changes

Merge branch 'master' into ts-loader-hmr

76a902b

vakrilov merged commit 0317729 into master May 9, 2019

ghost removed new PR review labels May 9, 2019

vakrilov deleted the ts-loader-hmr branch May 9, 2019 07:10

rosen-vladimirov added this to Done in CLI Team May 15, 2019