feat: make the plugin ready for AoT compilation #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
force-pushed
the
aot-support
branch
2 times, most recently
from
c90e4c8 to
7f91b9e
Compare
- add NgModule to export directiv - use ngc to generate metadata
| import * as frescoModule from "nativescript-fresco"; | ||
| import * as applicationModule from "application"; | ||
|
|
||
| import { registerElement } from "nativescript-angular/element-registry"; | ||
|
|
||
| registerElement("FrescoDrawee", () => FrescoDrawee); |
There was a problem hiding this comment.
Shouldn't we do this in our TNSFrescoModule so that the users can simply add the module to the imports without requirement to register the element.
There was a problem hiding this comment.
Yep, you are right. It would be easier for the users that way 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #28