Check if hook exists and don't reinstall. #1
Conversation
|
ping @tailsu, @teobugslayer |
| @@ -13,6 +13,7 @@ | |||
| "url": "https://github.com/NativeScript/nativescript-hook.git" | |||
| }, | |||
| "dependencies": { | |||
| "glob": "*", | |||
There was a problem hiding this comment.
I've read your concern, but in case new version of glob has breaking change, the current code will stop working, so I prefer to set exact version (or at least one starting with ^).
|
👍 from me after setting version of glob :) |
hdeshev
force-pushed
the
hdeshev/check-if-hook-exists
branch
from
9174b35 to
508e135
Compare
Do a fuzzy match, trying to handle cases like renaming a hook like nativescript-dev-typescript.js to 20-nativescript-dev-typescript.js when having several hooks executing in a defined order.
|
@rosen-vladimirov Fixed the glob version problem. I can merge and publish the hook, then open a PR for the |
|
yes, you can merge this PR and publish new version. For nativescript-dev-typecript, I'm not sure if it is required to publish new version as |
|
Gotcha. Publishing... |
Check if hook exists and don't reinstall.
Installing a hook checks if the hook script already exists (those should be kept in source control), and does nothing in that case.
Added a dependency to
glob, so that we do a fuzzy match and handle cases like renaming a hook script likenativescript-dev-typescript.jsto20-nativescript-dev-typescript.jsin order to enforce order between several hooks. Example:https://github.com/NativeScript/sample-ng-todomvc/tree/master/hooks/before-prepare
Note: the
globdependency is set to*so that we try to use any glob version that the user has installed. I'm not sure if that's the right thing to do here.