Skip to content

Improve Readability of all project python files massively #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve Readability of all project python files massively #400

wants to merge 2 commits into from

Conversation

SubhadityaMukherjee
Copy link

Massively improved code readability of every python script to increase paintability and help devs.
According to YAPF guidelines.

Check the code out and see its much easier to go through now.

@cla-bot
Copy link

cla-bot bot commented Oct 14, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @SubhadityaMukherjee.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@SubhadityaMukherjee
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 15, 2019
@cla-bot
Copy link

cla-bot bot commented Oct 15, 2019

The cla-bot has been summoned, and re-checked this pull request!

@KristianDD
Copy link

Hi @SubhadityaMukherjee,
Thank you for the effort and for creating a PR to our repository. There definitely are some readability improvement in the codebase.
The changes however seem to cause failures in our CI tests and are also in conflict with our pylint rules. We will close this PR and evaluate some of your suggestions that don’t conflict with our code-style guidelines in a separate PR. Thank you once again for the contribution. Feel free to choose some of the opened issues in our repository for future contributions.

@KristianDD KristianDD closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants