Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

Conversation

dangrima90
Copy link
Contributor

What is the current behavior?

When trying to use zones (Highcharts API; Example) The configuration is not affecting anything in the chart and HiZones are not implemented is shown in the console.

What is the new behavior?

Added the HiZones implementation to the library.

I hope that the mapper I did is correct, I added the properties I saw listed in the Android Highcharts API.

@cla-bot
Copy link

cla-bot bot commented May 31, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Daniel Grima.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented May 31, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @dangrima90.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@dangrima90
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label May 31, 2021
@cla-bot
Copy link

cla-bot bot commented May 31, 2021

The cla-bot has been summoned, and re-checked this pull request!

@shiv19
Copy link
Member

shiv19 commented May 31, 2021

Hi @dangrima90
Thank you for this PR!
The changes look good.

Next time you can copy the keys for the mapper from the typings file, it's easier to implement new handlers that way 😃

declare class HIZones extends HIChartsJSONSerializable {

@shiv19 shiv19 merged commit fc723ae into NativeScript:master May 31, 2021
@dangrima90
Copy link
Contributor Author

@shiv19 you're welcome - thanks for merging 👍

Will keep that in mind in case I end up making anymore changes in the future :)

@shiv19
Copy link
Member

shiv19 commented May 31, 2021

It's 1.16am where I live. So I'll release changes in this plugin in the morning :)
I'll leave a message here when it is released.

@dangrima90
Copy link
Contributor Author

Sounds good! Thank you :)

@shiv19
Copy link
Member

shiv19 commented May 31, 2021

Published as @nativescript/ui-charts@0.1.2 :)

@dangrima90
Copy link
Contributor Author

@shiv19 thanks a lot :) just tested it in the application I'm working on - so far so good 👍

@dangrima90 dangrima90 deleted the feature/hi-zones branch June 1, 2021 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants