-
-
Notifications
You must be signed in to change notification settings - Fork 334
feat(bundle): migrate to webpack #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think to remove outdated node versions. All versions before 8 LTS reach EOL ) |
Thanks @Delagen . Though moving to webpack will enable us splitting this package in small browser bundles, using ECMAScript latest syntax in the code etc, I wanted to check few things before merging this PR
|
|
For example? are we using any such function? As this module is pretty stable I see less features to be implemented in the future. |
For example ES2015 modules, async/await by default or something else... Need to check tables |
async/await is supported by node js. And we're not using that in our module anywhere. Can you please share some reference link where I can check those features? I couldn't find it through google. |
Many browser modules use ES2015 module model for efficient tree shaking |
I don't think that NodeJS bundle really needed at this time, but creating it can offer support more older versions, but with lack of some travis testing, or we can make some tweaks ) |
I you argue for removing it, I can fix it ) |
@Delagen With my own experience and under the guidance of my supervisors I've learnt that Plan for future but code for current . So yes please remove the part that is not expected to be used soon. |
Current is different for someone ) Some enterprise projects can use 0.12.x version or even older ) |
Yes please |
…ained versions of NodeJS from travis test
- 7 | ||
- 8 | ||
- 9 | ||
- 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to remove 7, 9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason to remove node version 7 & 9 from travis configuration?
They are not supported any more https://github.com/nodejs/Release#release-schedule |
Then I think we need to create some entry points for building multiple bundles |
Yes. And I'm thinking to remove XML to Nimn transformation as Nimn seems duplicate of Google's protobuf. |
This might be too late since it's already merged, but shouldn't rollup have been preferred over webpack, given that this is a library? Webpack has some overhead that rollup doesn't is my concern. It shouldn't be difficult to switch in the future though so might be best to keep with the flow you have going. |
@Zalastax Thanks . It seems interesting. We can have a look. Raising an issue so it doesn't skip |
Purpose / Goal
Simple make split bundles with entries in webpack.config.js
Use latest features of ECMAScript language without any hacks
Type
Please mention the type of PR
[ ]Bug Fix
[x]Refactoring / Technology upgrade
[ ]New Feature
Note : Please ensure that you've read contribution guidelines before raising this PR.