Few update to README #118
Merged
Few update to README #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix bad importer parser (use of `fastXmlParser` instead of `parser`) - fix indentation - remove the way to use `parser.js` directly from GitHub (it is served as `text/plain` and can't be parsed by browsers)
1 similar comment
|
As I remember, I highlighted the broken changes on README.md and removed them after few months. But yes we can maintain UPGRADE.md to highlight such changes. Applogies for your trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastXmlParserinstead ofparser)parser.jsdirectly from GitHub (it is served astext/plainand can't be parsed by browsers)Also, please, please, 🙏, publish a changelog with breaking changes from one version to an other. Or maybe create an UPGRADE.md file to tell people how to upgrade from a previous major version.
It's still related to that issue #35
I spend few hours fixing code while uprgading from 2.8.3.
Some options got renamed (
attrPrefix=>attributeNamePrefix), some options disapear (likeignoreNonTextNodeAttr), etc.Also
validate()function does not returnfalsebut an object now.