Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions spec/validator_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,13 +361,13 @@ describe("XMLParser", function() {
const result = validator.validate(xmlData).err;
expect(result).toEqual(expected);
});

it("should validate XML PIs", function () {
var xmlData = '<?xml version="1.0"?>'
+'<?mso-contentType?>'
+'<h1></h1>'
+'<?mso-contentType something="val"?>';

var result = validator.validate(xmlData);
expect(result).toBe(true);
});
Expand All @@ -379,11 +379,24 @@ describe("XMLParser", function() {
+'<?mso-contentType something="val"?>';

var expected = { code: 'InvalidChar', msg: 'char " is not expected .' }

var result = validator.validate(xmlData).err;
expect(result).toEqual(expected);
});

});
it('should validate xml with a "length" attribute', function() {
const xmlData = '<name length="1"></name>';

var result = validator.validate(xmlData);
expect(result).toEqual(true);
});

it("should not validate xml with repeated attributes", function() {
const xmlData = '<name length="bar" length="baz"></name>';

var expected = { code: 'InvalidAttr', msg: 'attribute length is repeated.' }

var result = validator.validate(xmlData).err;
expect(result).toEqual(expected);
});
});
2 changes: 1 addition & 1 deletion src/validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ function validateAttributeString(attrStr, options, regxAttrName) {
//if(attrStr.trim().length === 0) return true; //empty string

const matches = util.getAllMatches(attrStr, validAttrStrRegxp);
const attrNames = [];
const attrNames = {};

for (let i = 0; i < matches.length; i++) {
//console.log(matches[i]);
Expand Down