Skip to content

Conversation

damianed
Copy link

Purpose / Goal

There was an error where the localeRange option of the validate function only matched the start of the attribute name

Type

Please mention the type of PR

  • [x]Bug Fix
  • [ ]Refactoring / Technology upgrade
  • [ ]New Feature

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.487% when pulling b0e39f5 on damianed:master into 7b73fa2 on NaturalIntelligence:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.487% when pulling b0e39f5 on damianed:master into 7b73fa2 on NaturalIntelligence:master.

@amitguptagwl
Copy link
Member

@damianed Thanks for your PR. Can you please share the error you're facing? I would also like to get more detail like input XML etc. Probably, raising an issue and discussing there will be more appropriate.

@amitguptagwl
Copy link
Member

@damianed any update?

@damianed
Copy link
Author

damianed commented Feb 2, 2019

Sorry for not responding, I kept postponing it and then I forgot.
if i remember correctly, I was trying to use the library with an xml file with certain Spanish characters (e.g ñ, á, é etc) and I could not do it because it would throw an error. So it tried to fix that with this pull request.
But I don't think it even worked (part of the reason I kept postponing this response is that I made a pull request without testing it first and I felt ashamed :( ).
Sorry, I been trying to contribute to open source for a long time and when I find something I that I can contribute with I get over excited and rush my self.

@amitguptagwl
Copy link
Member

@damianed this is perfectly fine. If you really looking for some small issues to contribute, you can find some here: https://github.com/socialat/team

Feel free to contact back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants