Skip to content

Conversation

perevernihata
Copy link

Purpose / Goal

This PR is aimed to address issue with inconsistent parsing of leaf xml node depending on having attributes.

Type

  • [x]New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Benchmarks:

Before:

Running Suite: XML Parser benchmark
validation : 27318.44972450557 requests/second
xml to json : 25598.990886340493 requests/second
xml to json + json string : 22611.452524864457 requests/second
xml to json string : 3935.414783051609 requests/second
xml2js  : 7481.246469642413 requests/second

After:

Running Suite: XML Parser benchmark
validation : 16677.58957130443 requests/second
xml to json : 14956.997860785586 requests/second
xml to json + json string : 14365.03278613287 requests/second
xml to json string : 2784.9879303760063 requests/second
xml2js  : 5003.886648998017 requests/second

Bookmark this repository for further updates.

@coveralls
Copy link

coveralls commented Jun 27, 2021

Coverage Status

Coverage increased (+0.07%) to 88.049% when pulling 6b56ea0 on changingdigital:master into bbfecf9 on NaturalIntelligence:master.

@amitguptagwl
Copy link
Member

Not sure with the purpose of this PR. But similar feature is available. So closing this PR. still if you feel the need please raise an issue to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants