Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a data model for player statistics #46

Closed
Tracked by #7
Ne0Strix opened this issue Mar 28, 2023 · 1 comment
Closed
Tracked by #7

Create a data model for player statistics #46

Ne0Strix opened this issue Mar 28, 2023 · 1 comment

Comments

@Ne0Strix
Copy link
Owner

No description provided.

@Ne0Strix Ne0Strix mentioned this issue Mar 28, 2023
Closed
4 tasks
@Kranosos
Copy link
Collaborator

Kranosos commented Apr 7, 2023

Since the issue overlapped with Ne0Strix, this task is handled in commit f9f30c2 after a merge with Ne0Strix's feature branch

Kranosos added a commit that referenced this issue Apr 8, 2023
@Kranosos
relates to #31, #33, #46, #48 Data models are made and working with g…
3ed5adf 
…ame logic

This Commit handles multiple issues form 2 different user-stories, since they were very much intertwined and could hardly be handled separately. Now, the Models for the Player-Stats are created and are in working order. I made Changes to the Card-Class, since a few attributes were not needed (already handled in Effect Class). Also I refactored TurnManager so that the method calls could be more concise and readable.
Kranosos added a commit that referenced this issue Apr 13, 2023
@Kranosos
small changes to how effects work and new Class GameSession
84ce223 
All Classes that relate to how the effects from Cards are handled have gotten minor
changes to emphasize the used visitor pattern. Also The GameSession Class now replaces the TurnManager. The newly created PlayerFactory provides an easy way to instantiate new Players with all the needed components.

relates to #31, #33, #46, #48
@Kranosos Kranosos mentioned this issue Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Open Realms
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ne0Strix @Kranosos