initial code to sync buildings placement during gameplay #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame veins now (but do not mine when powered)
…s are linked now (atleast for miners)
hubastard
approved these changes
Mar 23, 2021
NebulaPatcher/NebulaPatcher.csproj
Outdated
Comment on lines
43
to
44
| <Reference Include="Assembly-CSharp"> | ||
| <Reference Include="Assembly-CSharp, Version=0.0.0.0, Culture=neutral, processorArchitecture=MSIL"> | ||
| <SpecificVersion>False</SpecificVersion> |
There was a problem hiding this comment.
Is this change intentional ?
NebulaWorld/Factory/EntityManager.cs
Outdated
| rot = rot | ||
| }, 0); | ||
|
|
||
| GameMain.mainPlayer.controller.actionBuild.NotifyBuilt(-0, ret); |
There was a problem hiding this comment.
I guess it should be 0 not -0
Therzok
reviewed
Mar 24, 2021
|
|
||
| namespace NebulaModel.Packets.Factory | ||
| { | ||
| public class EntityPlaced |
There was a problem hiding this comment.
This looks like another struct candidate
Therzok
reviewed
Mar 24, 2021
| for(int i = 0; i < recipe.productIds.Length; i++) | ||
| { | ||
| GameMain.mainPlayer.package.AddItemStacked(recipe.productIds[i], count); | ||
| } |
There was a problem hiding this comment.
Shouldn't this add to the Mecha's storage, not the main player's?
There was a problem hiding this comment.
Nevermind, this is debug code.
Therzok
reviewed
Mar 24, 2021
|
|
||
| for (int i = 0; i < veinsInAreaNonAlloc; i++) | ||
| { | ||
| if(minerType == EMinerType.Vein) |
There was a problem hiding this comment.
Over here, maybe moving the miner type switch above the loop might be better.
Therzok
reviewed
Mar 24, 2021
| minerPool[minerId].pcId = pcID; | ||
| } | ||
| minerPool[minerId].GetMinimumVeinAmount(GameMain.mainPlayer.factory, GameMain.mainPlayer.factory.veinPool); | ||
| // TODO: do some stuff with entitySignPool, is it important? |
There was a problem hiding this comment.
This is basically updating the image overlays on top of rendered objects. In example, logistics stations, recipes in assembler, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a start, there is still a lot missing. Whats working so far is:
It also includes a debug patch to free craft buildings and items.