-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zooming #134
base: master
Are you sure you want to change the base?
Conversation
I had a quick go with this, it's really cool. It seems to cause an issue with how ImGui checks the mouse position though, even if you never set any zoom. Functions like I haven't looked into it much, was wondering if you had any ideas? |
Hi, these are the issues i found while using this patch (without any modifications to my own code - I'm also using the docking-branch of imgui):
You can look at the issues in my App here: https://wasm.hcink.org/imnodes-134/ (web-version, which has the same issues as the desktop version for me - the app is still very WIP, but should be fine for demonstration of the issues above - moving the nodes around and selecting fields should be fine though - note that tooltips are only available on on some nodes) |
Hi there, and sorry about the long radio silence. I intend to tag a new release ASAP, then take a look at this pr & merge. |
All right, took the code for a spin. Agree with Auburns, this is really cool! I also noticed that some of the ImGui widget seems to be using untransformed grid space coordinates. Observed this with the menu bar getting highlighted, as well as when using The first thing which comes to mind is that would we be able to do the clip rect and vertex transformations from GCS? I know thedmd mentioned this in the original GitHub issue:
Do we know anything about why working with the GCS is bad? |
Hi all, just wanted to bump and say I like the idea. Could someone tell me what is the current status of this feature and are there any roadblocks? |
Have a look at #192 for my zoom implementation |
This adds supports for zooming.
The biggest change is that it makes everything between BeginNodeEditor() and EndNodeEditor() to work in grid space coordinates. This simplifies things a lot, since otherwise zooming adds yet another space, and this complicates things a lot. With this, there are basically just two spaces, the grid and the screen.
How it works: