Get the Playwright version from the package.json #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should be merged after #267
To run the end-to-end tests we execute Playwright using a spcific Docker tag. To know the docker tag that we need to use, we read the Playwright Docker image tag from a file placed in the root of the project. This provokes that every time @dependabot creates a pull request updating the
@playwright/test
package, tests fail because the Playwright Docker image is outdated.In this pull request, we read the Playwright version from the same
package.json
and in this way, we can remove the necessity of having the.playwright_docker_version
at all.