Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the Playwright version from the package.json #268

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

elchininet
Copy link
Collaborator

@elchininet elchininet commented Sep 8, 2024

This pull request should be merged after #267

To run the end-to-end tests we execute Playwright using a spcific Docker tag. To know the docker tag that we need to use, we read the Playwright Docker image tag from a file placed in the root of the project. This provokes that every time @dependabot creates a pull request updating the @playwright/test package, tests fail because the Playwright Docker image is outdated.

In this pull request, we read the Playwright version from the same package.json and in this way, we can remove the necessity of having the .playwright_docker_version at all.

As part of this pull request the pnpm-lock.yaml file has been deleted because at the moment we use yarn as package manager in the project.

@elchininet elchininet force-pushed the get_playwright_docker_version_from_package_json branch 7 times, most recently from 6612342 to bf639a7 Compare September 9, 2024 09:11
@elchininet elchininet marked this pull request as ready for review September 9, 2024 09:51
@elchininet elchininet force-pushed the get_playwright_docker_version_from_package_json branch from bf639a7 to ae1c139 Compare September 9, 2024 09:51
@NemesisRE NemesisRE merged commit a1799e5 into master Sep 10, 2024
5 checks passed
@elchininet elchininet deleted the get_playwright_docker_version_from_package_json branch September 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants