Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params to GetUsersByRoleName #392

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Add params to GetUsersByRoleName #392

merged 4 commits into from
Feb 15, 2023

Conversation

upils
Copy link
Contributor

@upils upils commented Dec 13, 2022

Add params to list more than a 100 users with GetUsersByRoleName

Fixing #391

Signed-off-by: Paul MARS <paul.mars@intrinsec.com>
@upils
Copy link
Contributor Author

upils commented Dec 20, 2022

Hi @Nerzal, is this possible to check this and let workflows run?

@Nerzal
Copy link
Owner

Nerzal commented Jan 9, 2023

Hi, if you merge the main branch the tests should be able to run now :)

@upils
Copy link
Contributor Author

upils commented Jan 9, 2023

Merge done, this should work now.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #392 (ec92883) into main (94bb940) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

❗ Current head ec92883 differs from pull request most recent head 62cb042. Consider uploading reports for the commit 62cb042 to get more accurate results

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   77.13%   77.08%   -0.06%     
==========================================
  Files           4        4              
  Lines        2152     2156       +4     
==========================================
+ Hits         1660     1662       +2     
- Misses        335      336       +1     
- Partials      157      158       +1     
Impacted Files Coverage Δ
client.go 75.40% <50.00%> (-0.06%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Paul MARS added 2 commits January 10, 2023 22:33
Signed-off-by: Paul MARS <paul.mars@intrinsec.com>
…e keycloak version

Signed-off-by: Paul MARS <paul.mars@intrinsec.com>
@upils
Copy link
Contributor Author

upils commented Jan 10, 2023

I added a test to improve coverage.

I noticed the docker image used was keycloak:latest, which now points to 20.0.2. They seems to have reworked the way UserInfo can be accessed (see keycloak/keycloak-documentation@533b730) so both GetUserInfo and GetRawUserInfo are broken in this keycloak version. So I have pinned the keycloak version to 19.0. I can remove this if you prefer.

Copy link
Owner

@Nerzal Nerzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the contribution

@Nerzal Nerzal merged commit b2ed4a5 into Nerzal:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants