Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit Linux executables in a Windows build and vice versa #319

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

guoci
Copy link
Member

@guoci guoci commented Mar 1, 2022

decreases Philosopher binaries size by about 45%

decreases `Philosopher` binaries size by about 45%
@prvst
Copy link
Collaborator

prvst commented Mar 1, 2022

Hi @guoci, can you describe to me what you did here? Slack works fine if you prefer.

@guoci
Copy link
Member Author

guoci commented Mar 1, 2022

In the philosopher.exe (Windows binary) you have Linux executables (proteinprohet, peptideprophet, etc) packed within it and vice versa. This causes the compiled Philosopher binaries to be way larger than it needs to be.
This commits uses build constraints to omit cross-OS executables. So now philosopher.exe will only have Windows executables within it.

@prvst
Copy link
Collaborator

prvst commented Mar 1, 2022

Did you test the program on both Windows and Linux, after removing the extra files?

@guoci
Copy link
Member Author

guoci commented Mar 1, 2022

not yet, will do later.

@prvst
Copy link
Collaborator

prvst commented Mar 1, 2022

OK, in that case, I'll hold the merging to the RC branch until we know it works. Thanks for the update.

@prvst prvst merged commit c74f5e2 into Nesvilab:rc-v4.2.1 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants