Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip/gnome-desktop3: Patch for uselocale() - not provided on NetBSD #19

Closed

Conversation

cirnatdan
Copy link
Member

No description provided.

@@ -0,0 +1,118 @@
$NetBSD$

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment the patches. pkglint will warn you about this.

locale = newlocale (LC_ALL_MASK, "C", (locale_t) 0);
g_assert_true (locale != (locale_t)0);
- save_locale = uselocale (locale);
+ //save_locale = uselocale (locale);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove these lines instead of commenting them out.

static void
test_weekday_setting (void)
{
+ g_test_skip("relies on uselocale(), not present on NetBSD");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#ifdef NETBSD?

@bsiegert
Copy link
Contributor

Also, it is worth submitting this upstream.

@bsiegert bsiegert self-assigned this Jun 18, 2020
@cirnatdan cirnatdan marked this pull request as draft June 18, 2020 13:00
@cirnatdan
Copy link
Member Author

@bsiegert thanks for the feedback. I should have mentioned it's still work-in-progress, I posted the PR to provide context for a discussion on #pkgsrc
Some of the patches are in fact a revert of changes done upstream. I am probably reintroducing some bugs. https://gitlab.gnome.org/GNOME/gnome-desktop/-/commit/74f8064291a492f05aaf47dd49d20bb7d89fc0df
I think a cleaner patch would be to provide an implementation of uselocale() on NetBSD.

@cirnatdan cirnatdan force-pushed the gnome-desktop-patch-uselocale branch from c920a5a to e8eaa48 Compare June 20, 2020 17:50
@cirnatdan cirnatdan force-pushed the gnome-desktop-patch-uselocale branch from e8eaa48 to 3d7dd29 Compare June 20, 2020 20:53
@cirnatdan
Copy link
Member Author

I commented and cleaned up the patches, then merged the changes manually - I have commit access. Thank you!

@cirnatdan cirnatdan closed this Jun 20, 2020
@cirnatdan cirnatdan deleted the gnome-desktop-patch-uselocale branch June 20, 2020 21:02
wip-sync pushed a commit that referenced this pull request Jul 8, 2020
Changes:
1.20
----
Some light fixes on the documentation and a cleaner setup.py so
the project looks decent on Pypi.

1.19
----
Address a issue with pygments installation on Python 2 and fix parallel
execution.

1.18
----
This release fixes #19 (add support for nested types) and improve
matching capabilities. Issue was linked to absolute include (like
relative include (include "toto.h").

1.17
----
 - Fix a python3 comptability issue
 - Add grep color mode
 - Fix multiple matches on one line
wip-sync pushed a commit that referenced this pull request Nov 14, 2020
Switched to use go-module.mk.

CHANGES:

* agent: Agent now properly returns a non-zero exit code on error, such as
  one due to template rendering failure. Using error_on_missing_key in the
  template config will cause agent to immediately exit on failure. In order
  to make agent properly exit due to continuous failure from template
  rendering errors, the old behavior of indefinitely restarting the
  template server is now changed to exit once the default retry attempt of
  12 times (with exponential backoff) gets exhausted. [GH-9670]
* token: Periodic tokens generated by auth methods will have the period
  value stored in its token entry. [GH-7885]

* core: New telemetry metrics reporting mount table size and number of
  entries [GH-10201]
* go: Updated Go version to 1.15.4 [GH-10366]

FEATURES:

* Couchbase Secrets: Vault can now manage static and dynamic credentials
  for Couchbase. [GH-9664]
* Expanded Password Policy Support: Custom password policies are now
  supported for all database engines.
* Integrated Storage Auto Snapshots (Enterprise): This feature enables an
  operator to schedule snapshots of the integrated storage backend and
  ensure those snapshots are persisted elsewhere.
* Integrated Storage Cloud Auto Join: This feature for integrated storage
  enables Vault nodes running in the cloud to automatically discover and
  join a Vault cluster via operator-supplied metadata.
* Key Management Secrets Engine (Enterprise; Tech Preview): This new secret
  engine allows securely distributing and managing keys to Azure cloud KMS
  services.
* Seal Migration: With Vault 1.6, we will support migrating from an auto
  unseal mechanism to a different mechanism of the same type. For example,
  if you were using an AWS KMS key to automatically unseal, you can now
  migrate to a different AWS KMS key.
* Tokenization (Enterprise; Tech Preview): Tokenization supports creating
  irreversible “tokens” from sensitive data. Tokens can be used in less
  secure environments, protecting the original data.
* Vault Client Count: Vault now counts the number of active entities (and
  non-entity tokens) per month and makes this information available via the
  "Metrics" section of the UI.

IMPROVEMENTS:

* auth/approle: Role names can now be referenced in templated policies
  through the approle.metadata.role_name property [GH-9529]
* auth/aws: Improve logic check on wildcard BoundIamPrincipalARNs and
  include role name on error messages on check failure [GH-10036]
* auth/jwt: Add support for fetching groups and user information from G
  Suite during authentication. [GH-123]
* auth/jwt: Adding EdDSA (ed25519) to supported algorithms [GH-129]
* auth/jwt: Improve cli authorization error [GH-137]
* auth/jwt: Add OIDC namespace_in_state option [GH-140]
* secrets/transit: fix missing plaintext in bulk decrypt response [GH-9991]
* command/server: Delay informational messages in -dev mode until logs have
  settled. [GH-9702]
* command/server: Add environment variable support for
  disable_mlock. [GH-9931]
* core/metrics: Add metrics for storage cache [GH_10079]
* core/metrics: Add metrics for leader status [GH 10147]
* physical/azure: Add the ability to use Azure Instance Metadata Service to
  set the credentials for Azure Blob storage on the backend. [GH-10189]
* sdk/framework: Add a time type for API fields. [GH-9911]
* secrets/database: Added support for password policies to all databases
  [GH-9641, and more]
* secrets/database/cassandra: Added support for static credential rotation
  [GH-10051]
* secrets/database/elasticsearch: Added support for static credential
  rotation [GH-19]
* secrets/database/hanadb: Added support for root credential & static
  credential rotation [GH-10142]
* secrets/database/hanadb: Default password generation now includes
  dashes. Custom statements may need to be updated to include quotes around
  the password field [GH-10142]
* secrets/database/influxdb: Added support for static credential rotation
  [GH-10118]
* secrets/database/mongodbatlas: Added support for root credential rotation
  [GH-14]
* secrets/database/mongodbatlas: Support scopes field in creations
  statements for MongoDB Atlas database plugin [GH-15]
* seal/awskms: Add logging during awskms auto-unseal [GH-9794]
* storage/azure: Update SDK library to use azure-storage-blob-go since
  previous library has been deprecated. [GH-9577]
* secrets/ad: rotate-root now supports POST requests like other secret
  engines [GH-70]
* ui: Add ui functionality for the Transform Secret Engine [GH-9665]
* ui: Pricing metrics dashboard [GH-10049]

BUG FIXES:

* auth/jwt: Fix bug preventing config edit UI from rendering [GH-141]
* cli: Don't open or overwrite a raft snapshot file on an unsuccessful
  vault operator raft snapshot [GH-9894]
* core: Implement constant time version of shamir GF(2^8) math [GH-9932]
* core: Fix resource leak in plugin API (plugin-dependent, not all plugins
  impacted) [GH-9557]
* core: Fix race involved in enabling certain features via a license change
* identity: Check for timeouts in entity API [GH-9925]
* secrets/database: Fix handling of TLS options in mongodb connection
  strings [GH-9519]
* secrets/gcp: Ensure that the IAM policy version is appropriately set
  after a roleset's bindings have changed. [GH-93]
* ui: Mask LDAP bindpass while typing [GH-10087]
* ui: Update language in promote dr modal flow [GH-10155]
* ui: Update language on replication primary dashboard for clarity
  [GH-10205]
* core: Fix bug where updating an existing path quota could introduce a
  conflict. [GH-10285]
wip-sync pushed a commit that referenced this pull request Nov 28, 2020
= libre Changelog

== [v1.1.0] - 2020-10-04

=== Added

- tls: functions to get the certificate issuer and subject [#18]
- uri: Added path field to struct uri and its decode to uri_decode [#22]
- tcp: add tcp_connect_bind [#24]
- http: support bind to laddr in http_request [#24]
- sipreg: support Cisco REGISTER keep-alives [#19]
- sip: websocket support [#26]

=== Fixed

- tls/openssl: fix X509_NAME win32/wincrypt.h conflict
- dns: listen on IPv4 and IPv6 socket [#27]
- main: fix/optimize windows file descriptors [#25]

=== Contributors (many thanks)

- Alfred E. Heggestad
- Christian Spielberger
- Christoph Huber
- Franz Auernigg
- Juha Heinanen
- Sebastian Reimers

== [v1.0.0] - 2020-09-08

=== Added

- sip: add trace
- sdp: sdp_media_disabled API function [#2]
- tls: add tls_set_selfsigned_rsa [#6]
- tls: add functions to verify server cert, purpose and hostname [#10]
- http: client should set SNI [#10]
- http: client should use tls functions to verify server certs, purpose
  and hostname [#10]
- sipreg: add proxy expires field and get function [#13]
- sipreg: make re-register interval configurable [#13]

=== Changed

- debian: Automatic cleanup after building debian package

=== Fixed

- Set SDK path (SYSROOT) using xcrun (fix building on macOS 10.14)
- tcp: close socket on windows if connection is aborted or reset [#1]
- rtmp: Fix URL path parsing (creytiv#245)
- ice: various fixes [baresip/baresip#925]
- openssl/tls: replace deprecated openssl 1.1.0 functions [#5]

=== Contributors (many thanks)

- Alfred E. Heggestad
- Christian Spielberger
- Christoph Huber
- Franz Auernigg
- juha-h
- Juha Heinanen
- Richard Aas
- Sebastian Reimers

[#25]: baresip/re#25
[#27]: baresip/re#27
[#26]: baresip/re#26
[#19]: baresip/re#19
[#24]: baresip/re#24
[#22]: baresip/re#22
[#18]: baresip/re#18
[#13]: baresip/re#13
[#10]: baresip/re#10
[#6]: baresip/re#6
[#5]: baresip/re#5
[#2]: baresip/re#2
[#1]: baresip/re#1

[v1.0.0]: baresip/re@v0.6.1...v1.0.0
[v1.1.0]: baresip/re@v1.0.0...v1.1.0
[Unreleased]: baresip/re@v1.1.0...HEAD
wip-sync pushed a commit that referenced this pull request Aug 21, 2021
2.1.1   2021-04-04
        - Makefile: fix undefined references with static builds (#19)

2.1.0   2020-02-11
        - Makefile: use "-f" with prove always (to show failed tests) (#13)
        - Stop searching in further dirs on errors except ENOENT #12
        - Makefile: do not rebuild t/static_%.c with updated gen-static-test
        - Add CMakeLists.txt and support for MSVC (#3)
        - Relax checks for extended capability to support new format (#5)
        - Makefile: use -Og with DEBUG=1 (#7)
        - unibi_from_mem: fix [clang-analyzer-deadcode.DeadStores] (#8)
        - Makefile: revisit regenerate-tests rule (#6)
        - unibi_from_term: handle $TERMINFO as curses does #2
wip-sync pushed a commit that referenced this pull request Jul 27, 2022
This updates to upstream 2.2.0 and as a notable local change does not hack
both shared and static libs into the build anymore. This is an unloved
endeavour and if we insist on static libs, we'd need to builds. But do we?

Tests are enabled now.

Upstream changes since 2.1.0:

New features:

    Allow compilation in ILP64 mode, PR #19

Major bug fixes:

    Use pointer macro to prevent integer overflow, PR #16

    Fix argument mismatches for implicitly defined functions (for gcc-10+ compatibility), PR #26

    No memory leaks on blacs_exit, PR #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants