Add missing records #63
Conversation
| @@ -11,6 +11,7 @@ def attributes=(attributes) | |||
| end | |||
|
|
|||
| def initialize_from_attributes_hash(attributes = {}) | |||
| attributes ||= {} | |||
There was a problem hiding this comment.
Could you give me some more information as to why this was needed? I haven't encountered any issues with this method in any of the other records in the gem.
There was a problem hiding this comment.
I sometimes experienced exceptions like:
[GEM_ROOT]/bundler/gems/netsuite-91c78614e5eb/lib/netsuite/support/attributes.rb:14→ initialize_from_attributes_hash
[GEM_ROOT]/bundler/gems/netsuite-91c78614e5eb/lib/netsuite/records/base_ref_list.rb:15→ initialize
[GEM_ROOT]/bundler/gems/netsuite-91c78614e5eb/lib/netsuite/actions/get_select_value.rb:51→ new
[GEM_ROOT]/bundler/gems/netsuite-91c78614e5eb/lib/netsuite/actions/get_select_value.rb:51→ get_select_value
There probably are conditions where and explicit value is passed, such as when an exception is thrown on the remote side (eg when two concurrent calls are made with the same credentials).
Maybe using a different approach (http://apidock.com/rails/ActiveSupport/CoreExtensions/Array/ExtractOptions/extract_options!) could be a better solution?
Conflicts: lib/netsuite.rb lib/netsuite/configuration.rb lib/netsuite/records/job.rb
|
@develon closing this out! Feel free to rebase and reopen! |
Hello,
I just added basic support for some missing SureTalk Records, and their related namespaces:
Give me some time to add specs...
Thanks a lot!
Lino