Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigProxyFactory support @DefaultValue for Collections #491

Closed
quidryan opened this issue Jun 15, 2017 · 0 comments · Fixed by #724
Closed

ConfigProxyFactory support @DefaultValue for Collections #491

quidryan opened this issue Jun 15, 2017 · 0 comments · Fixed by #724
Assignees
@elandau
Labels
v2

Comments

@quidryan
Copy link

Reference: https://github.com/Netflix/archaius/blob/2.x/archaius2-core/src/main/java/com/netflix/archaius/ConfigProxyFactory.java#L229

ConfigProxyFactory will throw an exception if a @DefaultValue is is provided for a Collection. Having the DefaultValue be a String makes it operationally easier to copy and modify in live systems. While I appreciate the default implementation on the interface, @DefaultValue is a nice standardization.

CC @elandau
@quidryan quidryan added the v2 label Jun 15, 2017
@twicksell twicksell mentioned this issue Jun 15, 2017
Merged
rgallardo-netflix added a commit that referenced this issue May 21, 2024
@rgallardo-netflix
Small fixes for collection types in configuration proxies:
0cb7ba8 
* Enable usage of the @DefaultValue annotation for methods with collection return types. Fixes: #491
* Enable usage of collection types in parametrized properties. Fixes: #681
@rgallardo-netflix rgallardo-netflix mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elandau elandau

Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Small fixes for collection types in configuration proxies: Netflix/archaius
2 participants
@quidryan @elandau