Feature/key transform #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shishirmk
force-pushed
the
feature/key_transform
branch
from
7808f84 to
cb624bd
Compare
|
I have a gem (that AMS(, and maybe others? Use)) called case_transform. It also has a native extension counterpart called case_transform-rust-extensions, which reduce conversion time by ~20x depending on the transform. |
|
@NullVoxPopuli Thanks for the suggestion. This is happening during class initialization so it shouldn't affect the serialization time. We are avoiding gems with native extensions for now. Here is a pull request where i have only two gems as runtime dependencies #40 |
shishirmk
force-pushed
the
feature/key_transform
branch
from
cb624bd to
610bd00
Compare
guilleiguaran
approved these changes
Feb 5, 2018
grossadamm
approved these changes
Feb 5, 2018
bf4
reviewed
Feb 8, 2018
| set_key_transform :camel # "some_key" => "SomeKey" | ||
| set_key_transform :camel_lower # "some_key" => "someKey" | ||
| set_key_transform :dash # "some_key" => "some-key" | ||
| set_key_transform :underscore # "some_key" => "some_key" |
There was a problem hiding this comment.
fwiw, the fastest key transform in AMS is :unaltered :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request the adds the key_transform functionality available in AMS. You can transform the keys and record types using 4 transforms. camel, camel_lower, underscore, dash.
This should address the question/feature request in #41
Additionally this is not backward compatible to use_hyphen. So we will have to bump up the version number accordingly.