Add #to_hash conversion protocol to object serializer #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to use a serializer with Rails, you have to explicitly call
serialize_hash
, e.g.Solution
While not a big problem at all, Rails does use the
to_hash
protocol under the hood in it'sas_json
core extension to Object. By implementing this interface you can conveniently pass a serializer instance directly to Rails'render
method.This may have already been considered and explicitly omitted from the library, but I didn't see any past issues mentioning it, so I thought I'd propose the change 🙂
I'm happy to discuss more and make changes as needed. I considered adding a test, but it seemed relatively low value, and I wasn't sure of the ideal location for such a test. Thanks for the wonderfully useful little library! ❤️💛💚💙