Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #142 #155

Merged
merged 5 commits into from
Aug 20, 2014
Merged

Fix Issue #142 #155

merged 5 commits into from
Aug 20, 2014

Conversation

allenxwang
Copy link

  • Added builders for HttpResourceGroup and HttpRequestTemplate
  • Make RibbonTransportFactory dependent on ClientConfigFactory and added APIs to create clients based on name

@cloudbees-pull-request-builder
Copy link

ribbon-pull-requests #162 SUCCESS
This pull request looks good

tbak
tbak reviewed Aug 20, 2014
View reviewed changes
ribbon-transport/src/main/java/com/netflix/ribbon/RibbonTransportFactory.java
public static class DefaultRibbonTransportFactory extends RibbonTransportFactory {
@Inject
public DefaultRibbonTransportFactory(ClientConfigFactory clientConfigFactory) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having @Inject annotation here forces all ribbon users to depend on the javax.inject.jar. Previously we had all injections isolated to ribbon-guice module.

tbak pushed a commit that referenced this pull request Aug 20, 2014
Merge pull request #155 from allenxwang/issue-142
4bd4aa3 
Fix Issue #142
@tbak tbak merged commit 4bd4aa3 into Netflix:master Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allenxwang @cloudbees-pull-request-builder @tbak