Fix Issue #156, #149 and #141 #157
Conversation
allenxwang
commented
Aug 22, 2014
allenxwang
commented
- Modularize annotation processing and make it easy to plug-in third party annotation processors
- Move EVCache annotation processing to its own module
- Added annotations for client properties
…on into pluggable-annotations
…able-annotations Conflicts: ribbon/src/main/java/com/netflix/ribbon/http/HttpResourceGroup.java ribbon/src/main/java/com/netflix/ribbon/proxy/MethodTemplateExecutor.java Move annotation processing to individual processor.
|
ribbon-pull-requests #166 SUCCESS |
| return null; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Multiple test classes are copied from ribbon to ribbon-evcache project. We could have instead dependency between test packages, and reuse the test classes across projects.
There was a problem hiding this comment.
I think the only way to reuse test classes is to move them to ribbon-test. "testCompile" dependency cannot be used for classes in src/test.
There was a problem hiding this comment.
Looks like this does the trick:
testCompile project(':ribbon').sourceSets.test.output
|
ribbon-pull-requests #167 SUCCESS |
| public <T> Observable<T> connectWithAction(final Func1<ObservableConnection<O, I>, Observable<T>> action) { | ||
| return connectWithAction(action, retryHandler); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is connectWithAction part of public API? Why is it needed?
There was a problem hiding this comment.
This is an unintended commit. I was experimenting this new API for certain udp client, but have not decided whether this should be offered as a Ribbon public API or should it just be part of the user code. I will remove this.
|
ribbon-pull-requests #168 SUCCESS |
