Refactoring of load balancer execution API and add ExecutionListener #165
Conversation
allenxwang
commented
Sep 10, 2014
allenxwang
commented
- Refactored the load balancer execution API as part of Refactor LoadBalancerExecutor to support state tracking #161
- Addressed issue Support execution listener for Ribbon transport clients #146
- Added meta info to Server to capture additional service and instance information in deployment environment
…nstance that encapsulate execution life cycle.
…eated builder for LoadBalancerCommand. Refactored NettyHttpClient.
…alancerrefactoring
…cutionContext and add APIs to get client properties.
|
ribbon-pull-requests #176 SUCCESS |
|
ribbon-pull-requests #177 SUCCESS |
| } | ||
|
|
||
| public CommandBuilder<T> withListeners(List<? extends ExecutionListener<?, T>> listeners) { | ||
| this.listeners = listeners; |
There was a problem hiding this comment.
Can withListeners be called multiple times? Might want to accumulate the listeners instead of replacing previous ones.
There was a problem hiding this comment.
Since the parameter is already a Collection, I feel it will seem strange if we do further accumulation for the with() method in a builder. At least it does not seem intuitive to me.
There was a problem hiding this comment.
We had the same thing in governator and eventually had to add a method called withAdditionalListeners for backwards compatibility. This caused a lot of ambiguity with sequences of withAdditionalListeners mixed with withListeners.
… to LoadBalancingHttpClient to be consistent with other namings.
|
ribbon-pull-requests #178 SUCCESS |
…Invoker. Added new APIs in ExecutionContextListenerInvoker to invoke listeners with passed in context.
|
ribbon-pull-requests #181 FAILURE |
|
ribbon-pull-requests #182 SUCCESS |
Refactoring of load balancer execution API and add ExecutionListener
