Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded test tags with metadata provided by cluster #493

Closed
denis-maiorov-brightsec opened this issue Oct 27, 2023 · 0 comments · Fixed by #554
Closed

Replace hardcoded test tags with metadata provided by cluster #493

denis-maiorov-brightsec opened this issue Oct 27, 2023 · 0 comments · Fixed by #554
Assignees
@denis-maiorov-brightsec
Labels
Type: enhancement New feature or request.

Comments

@denis-maiorov-brightsec
Copy link
Collaborator

The CLI uses hardcoded enum with test tags to show run:scan command help and assign default tests when no options are provided. It's now required to add new tag to the enum and bump version for clients to be able run a scan with a new test: see #492, #482, etc.

Public API now exposes auth free endpoints that provide metadata about tests including tags: https://app.brightsec.com/api/v1/docs/#/Scan%20Tests

In order to keep all the behavior async command builder has to be implemented. It requires to bump yargs to v17.
@denis-maiorov-brightsec denis-maiorov-brightsec added the Type: enhancement New feature or request. label Oct 27, 2023
@maksadbek maksadbek mentioned this issue Jun 24, 2024
Merged
@derevnjuk derevnjuk linked a pull request Jun 25, 2024 that will close this issue
feat(scan): remove hardcoded test types #554
Merged
@orubin orubin mentioned this issue Jun 26, 2024
Merged
derevnjuk pushed a commit that referenced this issue Jun 27, 2024
@maksadbek
build(deps): bump yargs from 16.2.0 to 17.7.2 (#556)
a65f8d1 
bump the yargs version to 17 to be able to use async builders

relates-to: #493
maksadbek added a commit that referenced this issue Jun 30, 2024
@maksadbek
feat(scan): fetch test types from API
12ff864 
replace hardcoded test types with a payload
from API.

closes #493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-maiorov-brightsec denis-maiorov-brightsec

Labels
Type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(scan): remove hardcoded test types NeuraLegion/bright-cli
1 participant
@denis-maiorov-brightsec