Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sampler): introduce max-length support for string pattern format sample #209

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Sep 14, 2023

closes #208

@ostridm ostridm added the Type: bug Something isn't working. label Sep 14, 2023
@ostridm ostridm requested a review from pmstss September 14, 2023 10:49
@ostridm ostridm self-assigned this Sep 14, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 14, 2023

Code Climate has analyzed commit f1dc434 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.7% (0.0% change).

View more on Code Climate.

@ostridm ostridm requested a review from derevnjuk September 14, 2023 10:57
@ostridm ostridm enabled auto-merge (squash) September 14, 2023 10:58
@ostridm ostridm requested a review from derevnjuk September 14, 2023 13:40
@ostridm ostridm merged commit 749b6d8 into master Sep 14, 2023
@ostridm ostridm deleted the fix-#208/introduce-max-length-support-for-string-pattern-format-sample branch September 14, 2023 14:47
ostridm added a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pattern string sampler does not take into account maxLength property
2 participants