fix(oas): improve consumes/produces configuration handling
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 29d656e and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.8% (0.0% change). View more on Code Climate. |
ostridm
force-pushed
the
fix-#210/use-application-json-when-consumes-configuration-missing
branch
from
1041454 to
6bd7082
Compare
derevnjuk
requested changes
Sep 18, 2023
packages/oas/src/converter/parts/headers/Oas2HeadersConveter.ts
Outdated
Show resolved
Hide resolved
packages/oas/tests/fixtures/missing-security.swagger.result.json
Outdated
Show resolved
Hide resolved
ostridm
force-pushed
the
fix-#210/use-application-json-when-consumes-configuration-missing
branch
from
b17bb25 to
2dedf06
Compare
pmstss
requested changes
Sep 20, 2023
auto-merge was automatically disabled
September 20, 2023 12:27
Pull request was converted to draft
ostridm
force-pushed
the
fix-#210/use-application-json-when-consumes-configuration-missing
branch
7 times, most recently
from
766f309 to
efa283e
Compare
ostridm
force-pushed
the
fix-#210/use-application-json-when-consumes-configuration-missing
branch
from
efa283e to
f9592b5
Compare
ostridm
changed the title
application/json when consumes media-type configuration missingconsumes/produces configuration missing
ostridm
changed the title
consumes/produces configuration missingconsumes/produces configuration handling
pmstss
requested changes
Sep 21, 2023
ostridm
force-pushed
the
fix-#210/use-application-json-when-consumes-configuration-missing
branch
3 times, most recently
from
936fb2e to
02a75e3
Compare
ostridm
force-pushed
the
fix-#210/use-application-json-when-consumes-configuration-missing
branch
from
02a75e3 to
29d656e
Compare
pmstss
approved these changes
Sep 21, 2023
derevnjuk
approved these changes
Sep 21, 2023
ostridm
deleted the
fix-#210/use-application-json-when-consumes-configuration-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #210