Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeuroML 2.2 release #152

Merged
merged 231 commits into from
Dec 16, 2021
Merged

NeuroML 2.2 release #152

merged 231 commits into from
Dec 16, 2021

Conversation

pgleeson
Copy link
Member

@pgleeson pgleeson commented Dec 2, 2021

No description provided.

sanjayankur31 and others added 30 commits March 23, 2021 18:58
Follows the same logic as -neuron, but also includes an additional -np
flag for MPI runs that NetPyNE supports.

Fixes #80
get_window_title and set_window_title have been deprecated in matplotlib
version 3.4 and will be dropped in future releases.

Reference: https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.4.0.html#backend-deprecations

Fixes #95
feat: update matplotlib usage to remove deprecated methods
enh(pynml): add -netpyne option
feat: add function to validate NeuroML2 LEMS file
exit() is a helper for the interactive shell, sys.exit() should be used
in programs
Enable documentation on RTD
Make it ignore packages where type information is not available
Also update links to schema docs
sanjayankur31 and others added 13 commits December 8, 2021 12:19
The complete libNeuroML API is based on lxml.etree now, and this
unfortunately cannot be pickled. So we cannot pass the NeuroMLDocument
to the run_simulation function when using pp for parallel runs.

Instead, we pass None and let the run_simulation method read in the
template NeuroML file and create the NeuroMLDocument there as required.
- Also, printing stderr output from jnml command
* development:
  ci: remove `bin` from NEURON_HOME
  ci: export NEURON_HOME
  ci: add NEURON to requirements
  ci: also run tuning example
  feat: print necessary messages in the tuner
  chore(NeuroMLTuner): document return values for optimisation funcs
pip install modelspec version for dev
@sanjayankur31
Copy link
Member

sanjayankur31 commented Dec 10, 2021

Something is pulling in typing into all builds which isn't needed on 3.7+, and that seems to be causing the error:

python/typing#573

It doesn't seem to be any of our tools---we have typing; python_version<"3.5" everywhere I can find, so could be one of the deps maybe..

pgleeson and others added 4 commits December 10, 2021 12:27
Nicer to just pass a string instead of a StringIO object, and this also
allows us to close the StringIO object also.
@pgleeson
Copy link
Member Author

@sanjayankur31 It's probably because this test on master uses the master branch of libneuroml pylems, etc. which haven't been updated in a while, which probably have previous typing/py39 issues. Should be resolved when those repos have dev merged to master (next week...)

@pgleeson pgleeson merged commit ecd1e49 into master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants