Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend types.util.correctType to support empty arrays #389

Merged
merged 8 commits into from
Jan 25, 2022

Conversation

cechava
Copy link
Collaborator

@cechava cechava commented Jan 13, 2022

fixes issue #388

@cechava cechava marked this pull request as ready for review January 13, 2022 19:00
@cechava
Copy link
Collaborator Author

cechava commented Jan 13, 2022

current test errors will disappear with fixes from PR #385

@cechava cechava marked this pull request as draft January 13, 2022 21:13
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #389 (8996f39) into master (ddc825d) will increase coverage by 0.45%.
The diff coverage is 97.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   85.25%   85.71%   +0.45%     
==========================================
  Files         125      125              
  Lines        4613     4698      +85     
==========================================
+ Hits         3933     4027      +94     
+ Misses        680      671       -9     
Impacted Files Coverage Δ
+types/+util/+dynamictable/addRow.m 92.30% <ø> (-7.70%) ⬇️
+types/+util/+dynamictable/checkConfig.m 92.59% <95.65%> (+17.59%) ⬆️
+tests/+system/AlignedSpikeTimesUtilityTest.m 100.00% <100.00%> (ø)
+tests/+system/DynamicTableTest.m 99.52% <100.00%> (+11.37%) ⬆️
+types/+util/correctType.m 88.37% <100.00%> (ø)
+types/+util/+dynamictable/getTypeMap.m 88.00% <0.00%> (-12.00%) ⬇️
+types/+util/+dynamictable/addVarargRow.m 91.30% <0.00%> (-2.18%) ⬇️
+types/+untyped/+datapipe/BoundPipe.m 78.29% <0.00%> (-1.56%) ⬇️
+types/+util/+dynamictable/addRawData.m 85.29% <0.00%> (-1.48%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07209c3...8996f39. Read the comment docs.

@cechava cechava marked this pull request as ready for review January 13, 2022 23:04
@cechava cechava requested a review from lawrence-mbf January 13, 2022 23:04
@cechava cechava merged commit 1cdd68b into NeurodataWithoutBorders:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants