Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change max and min to more compatible version #438

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

bendichter
Copy link
Contributor

Motivation

fix #437

@bendichter bendichter requested a review from lawrence-mbf June 22, 2022 13:49
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #438 (6bf9af1) into master (70bed03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   86.06%   86.07%           
=======================================
  Files         125      125           
  Lines        5125     5126    +1     
=======================================
+ Hits         4411     4412    +1     
  Misses        714      714           
Impacted Files Coverage Δ
+io/+space/findShapes.m 95.65% <100.00%> (+0.09%) ⬆️
+types/+util/correctType.m 88.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70bed03...6bf9af1. Read the comment docs.

@lawrence-mbf
Copy link
Collaborator

@bendichter There are a few more max() usages that are not compatible with 2017b. I can take a look at fixing those.

@lawrence-mbf
Copy link
Collaborator

[~, largestSegInd] = max(subStops - subStarts + 1, [], 'linear');
for instance. max(..., [], 'linear') is not supported in 2017b

Copy link
Collaborator

@lawrence-mbf lawrence-mbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bendichter bendichter merged commit 8afab87 into master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Syntax valid only after Matlab 2018b
2 participants