fix invalid dynamic table typing #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should now use the NWB language spec.
Function name didn't match file name.
Mappings now go through file.mapType before reaching checkDtype or correctType. This ensures that a strict subset of types are actually used for type checking and that all documentation uses MATLAB types instead of NWB types.
Should not use nwb schema language, but MATLAB language.
lawrence-mbf
changed the title
- Remove redundant data checks and simply check data validity post-hoc.
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 87.48% 87.60% +0.12%
==========================================
Files 127 127
Lines 5232 5236 +4
==========================================
+ Hits 4577 4587 +10
+ Misses 655 649 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@lawrence-mbf I'm still getting an error with: nwb = NwbFile( ...
'session_description', 'mouse in open exploration',...
'identifier', 'Mouse5_Day3', ...
'session_start_time', datetime(2018, 4, 25, 2, 30, 3) ...
);
trials = types.core.TimeIntervals(...
'description', 'trials table', ...
'colnames', {'start_time', 'stop_time', 'is_correct'} ...
);
trials.addRow('start_time', 1., 'stop_time', 2., 'is_correct', true);
trials.addRow('start_time', 1.5, 'stop_time', 2., 'is_correct', false);
trials.addRow('start_time', 2.5, 'stop_time', 2.5, 'is_correct', true); |
|
@bendichter That's error is being worked on in #461. this pr is for #457 |
|
@bendichter sorry, #461 |
bendichter
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
Motivation
Match language spec here: https://schema-language.readthedocs.io/en/latest/description.html#sec-dtype
How to test the behavior?
See #457
Checklist
fix #XXwhereXXis the issue number?