Add numeric stack constraints and telemetry preflight #23
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| monkeypatch.setattr("toptek.main.build_features", fake_build_features) | ||
| monkeypatch.setattr("toptek.main.model.train_classifier", fake_train_classifier) | ||
| monkeypatch.setattr("toptek.main.data.sample_dataframe", lambda: _sample_dataframe(140)) | ||
| monkeypatch.setattr( | ||
| "toptek.main.data.sample_dataframe", lambda: _sample_dataframe(140) | ||
| ) | ||
|
|
||
| args = argparse.Namespace(cli="train", model="logistic", symbol="ES", timeframe="5m", lookback="90d", start=None) | ||
| args = argparse.Namespace( | ||
| cli="train", | ||
| model="logistic", | ||
| symbol="ES", | ||
| timeframe="5m", | ||
| lookback="90d", | ||
| start=None, |
There was a problem hiding this comment.
The CLI now casts args.lookback to int and forwards it to data.sample_dataframe(lookback), but the integration test still stubs sample_dataframe with a zero‑argument lambda and builds the namespace with lookback="90d". When run_cli executes, the stub will raise TypeError (unexpected positional argument) or ValueError when int("90d") is evaluated, so the test suite cannot run. The stub needs to accept the new positional argument and the test should pass an integer lookback to match the updated CLI contract.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e0a95a63848329be8889df4c352ddd