Skip to content

Conversation

Newcoderorigin
Copy link
Owner

Summary

  • add an offline-first data bank with deterministic synthetic/yfinance providers, parquet ingest CLI, and catalog support for downstream loaders
  • implement a nightly preparation pipeline that ingests history, builds features, trains a calibrated classifier, optimises thresholds, and writes briefs/model artifacts while checking drift
  • expose confidence scoring utilities, UI widgets, strategy ranking, advisor surfaces, a deterministic bench harness, and CI coverage alongside targeted tests and docs updates

Testing

  • ruff check
  • black .
  • mypy --config-file mypy.ini toptek/databank toptek/pipelines toptek/confidence toptek/rank toptek/advisor tests/test_databank.py tests/test_prep_nightly.py tests/test_confidence.py tests/test_advisor.py tests/test_ranker.py
  • pytest

https://chatgpt.com/codex/tasks/task_e_68e13e02d3e483299d89c6c425ef6da2

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +35 to +40
def to_json(self, path: Path) -> None:
path.write_text(
pd.DataFrame([s.__dict__ for s in self.scores]).to_json(
orient="records", indent=2
),
encoding="utf-8",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove unsupported indent argument in RankResult JSON writer

The new RankResult.to_json calls pd.DataFrame(...).to_json(orient="records", indent=2). Pandas’ DataFrame.to_json does not accept an indent keyword (it is only available on json.dumps). At runtime this method will raise TypeError: to_json() got an unexpected keyword argument 'indent', so any attempt to persist rankings as JSON fails. Drop the indent argument and let callers pretty‑print if needed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant