-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Loadout Items #1750
Initial Loadout Items #1750
Conversation
Like this, but a few comments (didn't mean to accidentally convert it from a draft earlier): Not all LoadoutFiles will have a Hash/Size, reified deletes are the current example, but generated files would be another. I think we should split apart LoadoutFile into a model with |
I'm not a fan of the current design's (code in |
This is where the |
@Al12rs and I couldn't come up with better names for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok from me, but I'd like to hear from @halgari when he comes back today for a few things above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, it seems parts of the app still expect DeletedFile to have Hash and size since they were including File before.
4b0d311
to
ad96d94
Compare
03524ad
to
2a36350
Compare
@Al12rs everything should pass. I've temporarily disabled the |
Part of #1336.
I believe that this super simple design will get us very far. The main concern was "mods" and how we represent them. With the advent of collections, we'd also need to figure out how to represent those as well.
The simplest solution is the following (editor):
With this design, we can easily represent mods, collections, and other stuff using groups. Besides having groups, a
LoadoutItem
has aSource
. I'm not 100% whether we want to have this be required or not, but what this allows us to do, is create a link between the Loadout and the Library added in my recent PRs.The UI for the library is going to show library items that have been added manually or downloaded via Nexus Mods. For the Loadout, we're essentially going to do the same: get all loadout items where the library item is one of the desired types.
This massively simplifies how we make the relationship between the loadout and library in the UI clear to the user, and it allows us to implement many UI designs much more easily.