Chore: data types namespacing #1145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#1121
Changes proposed in this pull request
Move enums and structs into their interfaces instead of having them at file level.
The
ClaimMethod
enum and the following structs that were left as is are because they're being referenced in other contracts.Note: There's also a workaround that can be used sometimes to avoid clashes in the future by importing only the desired symbols from the target file using the following syntax:
import { IIndividualClaims } from "./IIndividualClaims.sol";
. This way theConfiguration
struct wouldn't be imported. This won't always work, for example if you import two files while both are importing of everything fromIIndividualClaims.sol
.Test plan
Used the following script to generate a file that imports all interfaces:
IERC20 is excluded because of the ^0.5.0 pragma which breaks the import as there's more than one IERC20: one for 0.5 pragma, one for 0.8.
The generated contract compiled fine but I don't feel like it's a good idea to add it to git because:
So instead of slowing down the compilation with newer files we should rather watch out for these issues when reviewing PRs.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: