Audit: Cover products

.solcover.js

@@ -53,12 +53,13 @@ module.exports = {
     'abstract/',
     'external/',
     'interfaces/',
+    'libraries/',
     'mocks/',
     'modules/assessment/AssessmentViews.sol',
     'modules/cover/CoverViewer.sol',
-    'modules/cover/ProductsV1.sol',
     'modules/governance/external',
     'modules/legacy',
+    'modules/staking/StakingViewer.sol',
     'modules/token/external',
     'utils/',
   ],

contracts/interfaces/ICompleteStakingPoolFactory.sol

@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-3.0-only
+
+pragma solidity >=0.5.0;
+
+import "./IStakingPoolFactory.sol";
+
+/**
+ * @dev IStakingPoolFactory is missing the changeOperator() and operator() functions.
+ * @dev Any change to the original interface will affect staking pool addresses
+ * @dev This interface is created to add the missing functions so it can be used in other contracts.
+ */
+interface ICompleteStakingPoolFactory is IStakingPoolFactory {
+
+  function operator() external view returns (address);
+
+  function changeOperator(address newOperator) external;
+}

contracts/interfaces/ICover.sol

@@ -5,42 +5,21 @@ pragma solidity >=0.5.0;
 import "./ICoverNFT.sol";
 import "./IStakingNFT.sol";
 import "./IStakingPool.sol";
-import "./IStakingPoolFactory.sol";
+import "./ICompleteStakingPoolFactory.sol";
 
-/* ========== DATA STRUCTURES ========== */
+/* io structs */
 
 enum ClaimMethod {
   IndividualClaims,
   YieldTokenIncidents
 }
 
-// Basically CoverStatus from QuotationData.sol but with the extra Migrated status to avoid
-// polluting Cover.sol state layout with new status variables.
-enum LegacyCoverStatus {
-  Active,
-  ClaimAccepted,
-  ClaimDenied,
-  CoverExpired,
-  ClaimSubmitted,
-  Requested,
-  Migrated
-}
-
-/* io structs */
-
 struct PoolAllocationRequest {
   uint40 poolId;
   bool skip;
   uint coverAmountInAsset;
 }
 
-struct RequestAllocationVariables {
-  uint previousPoolAllocationsLength;
-  uint previousPremiumInNXM;
-  uint refund;
-  uint coverAmountInNXM;
-}
-
 struct BuyCoverParams {
   uint coverId;
   address owner;
@@ -55,28 +34,6 @@ struct BuyCoverParams {
   string ipfsData;
 }
 
-struct ProductParam {
-  string productName;
-  uint productId;
-  string ipfsMetadata;
-  Product product;
-  uint[] allowedPools;
-}
-
-struct ProductTypeParam {
-  string productTypeName;
-  uint productTypeId;
-  string ipfsMetadata;
-  ProductType productType;
-}
-
-struct ProductInitializationParams {
-  uint productId;
-  uint8 weight;
-  uint96 initialPrice;
-  uint96 targetPrice;
-}
-
 /* storage structs */
 
 struct PoolAllocation {
@@ -101,31 +58,27 @@ struct CoverSegment {
   uint24 globalCapacityRatio;
 }
 
-struct Product {
-  uint16 productType;
-  address yieldTokenAddress;
-  // cover assets bitmap. each bit represents whether the asset with
-  // the index of that bit is enabled as a cover asset for this product
-  uint32 coverAssets;
-  uint16 initialPriceRatio;
-  uint16 capacityReductionRatio;
-  bool isDeprecated;
-  bool useFixedPrice;
-}
+interface ICover {
 
-struct ProductType {
-  uint8 claimMethod;
-  uint32 gracePeriod;
-}
+  /* ========== DATA STRUCTURES ========== */
 
-struct ActiveCover {
-  // Global active cover amount per asset.
-  uint192 totalActiveCoverInAsset;
-  // The last time activeCoverExpirationBuckets was updated
-  uint64 lastBucketUpdateId;
-}
+  /* internal structs */
 
-interface ICover {
+  struct RequestAllocationVariables {
+    uint previousPoolAllocationsLength;
+    uint previousPremiumInNXM;
+    uint refund;
+    uint coverAmountInNXM;
+  }
+
+  /* storage structs */
+
+  struct ActiveCover {
+    // Global active cover amount per asset.
+    uint192 totalActiveCoverInAsset;
+    // The last time activeCoverExpirationBuckets was updated
+    uint64 lastBucketUpdateId;
+  }
 
   /* ========== VIEWS ========== */
 
@@ -142,82 +95,49 @@ interface ICover {
     uint segmentId
   ) external view returns (CoverSegment memory);
 
-  function products(uint id) external view returns (Product memory);
-
-  function productTypes(uint id) external view returns (ProductType memory);
-
-  function stakingPool(uint index) external view returns (IStakingPool);
-
-  function productNames(uint productId) external view returns (string memory);
-
-  function productsCount() external view returns (uint);
-
-  function productTypesCount() external view returns (uint);
+  function recalculateActiveCoverInAsset(uint coverAsset) external;
 
   function totalActiveCoverInAsset(uint coverAsset) external view returns (uint);
 
-  function globalCapacityRatio() external view returns (uint);
+  function getGlobalCapacityRatio() external view returns (uint);
 
-  function globalRewardsRatio() external view returns (uint);
+  function getGlobalRewardsRatio() external view returns (uint);
 
-  function getPriceAndCapacityRatios(uint[] calldata productIds) external view returns (
+  function getGlobalMinPriceRatio() external pure returns (uint);
+
+  function getGlobalCapacityAndPriceRatios() external view returns (
     uint _globalCapacityRatio,
-    uint _globalMinPriceRatio,
-    uint[] memory _initialPriceRatios,
-    uint[] memory _capacityReductionRatios
+    uint _globalMinPriceRatio
   );
 
-  /* === MUTATIVE FUNCTIONS ==== */
+  function GLOBAL_MIN_PRICE_RATIO() external view returns (uint);
 
-  function addLegacyCover(
-    uint productId,
-    uint coverAsset,
-    uint amount,
-    uint start,
-    uint period,
-    address newOwner
-  ) external returns (uint coverId);
+  /* === MUTATIVE FUNCTIONS ==== */
 
   function buyCover(
     BuyCoverParams calldata params,
     PoolAllocationRequest[] calldata coverChunkRequests
   ) external payable returns (uint coverId);
 
-  function setProductTypes(ProductTypeParam[] calldata productTypes) external;
-
-  function setProducts(ProductParam[] calldata params) external;
-
   function burnStake(
     uint coverId,
     uint segmentId,
     uint amount
   ) external returns (address coverOwner);
 
+  function changeStakingPoolFactoryOperator() external;
+
   function coverNFT() external returns (ICoverNFT);
 
   function stakingNFT() external returns (IStakingNFT);
 
-  function stakingPoolFactory() external returns (IStakingPoolFactory);
-
-  function createStakingPool(
-    bool isPrivatePool,
-    uint initialPoolFee,
-    uint maxPoolFee,
-    ProductInitializationParams[] calldata productInitParams,
-    string calldata ipfsDescriptionHash
-  ) external returns (uint poolId, address stakingPoolAddress);
-
-  function isPoolAllowed(uint productId, uint poolId) external returns (bool);
-  function requirePoolIsAllowed(uint[] calldata productIds, uint poolId) external view;
+  function stakingPoolFactory() external returns (ICompleteStakingPoolFactory);
 
   /* ========== EVENTS ========== */
 
-  event ProductSet(uint id, string ipfsMetadata);
-  event ProductTypeSet(uint id, string ipfsMetadata);
   event CoverEdited(uint indexed coverId, uint indexed productId, uint indexed segmentId, address buyer, string ipfsMetadata);
 
   // Auth
-  error OnlyMemberRolesCanOperateTransfer();
   error OnlyOwnerOrApproved();
 
   // Cover details
@@ -227,26 +147,19 @@ interface ICover {
   error CoverAmountIsZero();
 
   // Products
-  error ProductDoesntExist();
-  error ProductTypeNotFound();
-  error ProductDoesntExistOrIsDeprecated();
-  error InvalidProductType();
+  error ProductNotFound();
+  error ProductDeprecated();
   error UnexpectedProductId();
-  error PoolNotAllowedForThisProduct(uint productId);
 
   // Cover and payment assets
   error CoverAssetNotSupported();
   error InvalidPaymentAsset();
   error UnexpectedCoverAsset();
-  error UnsupportedCoverAssets();
   error UnexpectedEthSent();
   error EditNotSupported();
 
   // Price & Commission
   error PriceExceedsMaxPremiumInAsset();
-  error TargetPriceBelowGlobalMinPriceRatio();
-  error InitialPriceRatioBelowGlobalMinPriceRatio();
-  error InitialPriceRatioAbove100Percent();
   error CommissionRateTooHigh();
 
   // ETH transfers
@@ -256,11 +169,8 @@ interface ICover {
   error ReturningEthRemainderToSenderFailed();
 
   // Misc
-  error AlreadyInitialized();
   error ExpiredCoversCannotBeEdited();
   error CoverNotYetExpired(uint coverId);
-  error CoverAlreadyExpired(uint coverId);
   error InsufficientCoverAmountAllocated();
   error UnexpectedPoolId();
-  error CapacityReductionRatioAbove100Percent();
 }

contracts/interfaces/ICoverBroker.sol

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-3.0-only
 
-pragma solidity ^0.8.18;
+pragma solidity >=0.5.0;
 
 import "@openzeppelin/contracts-v4/token/ERC20/IERC20.sol";
 

contracts/interfaces/ICoverNFT.sol

@@ -12,6 +12,8 @@ interface ICoverNFT is IERC721 {
 
   function changeOperator(address newOperator) external;
 
+  function changeNFTDescriptor(address newNFTDescriptor) external;
+
   function totalSupply() external view returns (uint);
 
   function name() external view returns (string memory);