-
Notifications
You must be signed in to change notification settings - Fork 66
feat: Add NexusViewer #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add NexusViewer #1172
Conversation
1803b43
to
8dcacb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
8dcacb3
to
05fb658
Compare
05fb658
to
006008b
Compare
* setAggregatedTokens to NVMockStakingViewer
968e4b8
to
de4d993
Compare
de4d993
to
2f70afd
Compare
b02bef1
to
344978d
Compare
344978d
to
8970723
Compare
function getManagerTokenRewards(address manager) external view returns (Token[] memory tokens); | ||
|
||
function getManagerTotalRewards(address member) external view returns (uint managerTotalRewards); | ||
|
||
function getManagerPoolsAndRewards(address manager) external view returns (ManagerPoolsAndRewards memory); | ||
|
||
function getManagerRewards(uint[] memory poolIds) external view returns (Token[] memory tokens); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please stay consistent with naming the function argument: either
manager
ormember
across these functions - Slight scope creep:
getManagerTokenRewards
&getManagerRewards
could be renamed to something a bit more descriptive:getManagerTokenRewardsByAddr
,getManagerTokenRewardsByPoolIds
,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll change to getManagerTokenRewardsByAddr
but we'll need to keep getManagerRewards
to avoid a breaking change as its an existing method
Context
Closes #1166
Add NexusViewer to provide a unified view of system-wide data from various contracts within the Nexus Mutual platform
NOTE: this PR is behind #1164
Changes proposed in this pull request
Test plan
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: