-
Notifications
You must be signed in to change notification settings - Fork 66
feat: Add batch NXM withdrawal + Staking Pool fixes #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rackstar
merged 83 commits into
release-candidate
from
audit/staking-pool-fixes-and-batch-withdrawal
Aug 22, 2024
Merged
feat: Add batch NXM withdrawal + Staking Pool fixes #1209
rackstar
merged 83 commits into
release-candidate
from
audit/staking-pool-fixes-and-batch-withdrawal
Aug 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2024
* update unit tests with custom errors
9 tasks
eef8c86
to
7087907
Compare
9 tasks
…o-pool-struct-staking-viewer feat: Add metadataIpfsHash to StakingViewer Pool struct
roxdanila
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Audit Docs
Findings
Audit Findings
There are 2 informational comments that we decided not to address, these are both on temporary functions that will be deprecated shortly after executing:
Changes proposed in this pull request
Test plan
Add unit tests on all fixes