Skip to content

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Aug 12, 2024

Overview

Audit Docs

Findings

Audit Findings

There are 2 informational comments that we decided not to address, these are both on temporary functions that will be deprecated shortly after executing:

  • Index out of bounds - adding validation here merely transforms "index out of bounds" error to a nicer message. Moreover, we would have fork tests to ensure that we pass the correct parameters so this error should not happen when we invoke it on main-net
  • Custom Errors - it should be inconsequential if we keep it as requires specially since it will be deprecated shortly after.

Changes proposed in this pull request

Test plan

Add unit tests on all fixes

@rackstar rackstar force-pushed the audit/staking-pool-fixes-and-batch-withdrawal branch from eef8c86 to 7087907 Compare August 20, 2024 08:58
@rackstar rackstar mentioned this pull request Aug 20, 2024
9 tasks
@rackstar rackstar changed the title Audit: Staking Pool fixes and batch NXM withdrawal audit: Staking Pool fixes and batch NXM withdrawal Aug 20, 2024
@rackstar rackstar self-assigned this Aug 20, 2024
@rackstar rackstar changed the title audit: Staking Pool fixes and batch NXM withdrawal feat: Add batch NXM withdrawal + Staking Pool fixes Aug 22, 2024
@rackstar rackstar merged commit 7bc761b into release-candidate Aug 22, 2024
6 checks passed
@rackstar rackstar deleted the audit/staking-pool-fixes-and-batch-withdrawal branch August 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants